Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for options type while creating network #1136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

Added check for options type while creating network #1136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/protocol/network.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ class Network {
if (typeof options === 'string')
options = networks[options];

if (options instanceof Object)
assert(!options.type, 'Unknown network.');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have added a ! by mistake. Moreover we should use assert(options.type && options.type in networks, 'Unknown network.') to check if the options object has a type and if it does then it is a valid type.

Copy link

@Harsh06-afk Harsh06-afk Jan 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, is anyone working on this PR or not? If not, can I work on this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure go ahead 😃


assert(options, 'Unknown network.');

if (Network[options.type])
Expand Down