Fix for issue #144. #155
Merged
Fix for issue #144. #155
+109
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…poorly defined and inconsistently used. Added a `vector` option to enforce a vector/scalar return, and `dim` is only used for checking. Fixed tests and all calls to `getunit()` where this case occurred. Also fixed some minor sphinx doco formatting problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dimoption ofgetunit()was poorly defined and inconsistently used. Added avectoroption to enforce a vector/scalar return, anddimis only used for checking. Fixed/extended unit tests and all calls togetunit()where this confusion occurred. Also fixed some minor sphinx doco formatting problems.This version of the PR excludes the commit noise from the ongoing black formatting issue.