Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple JointState msg support #474

Merged
merged 9 commits into from
Sep 10, 2024
Merged

Add simple JointState msg support #474

merged 9 commits into from
Sep 10, 2024

Conversation

llee-bdai
Copy link
Collaborator

Change Overview

Adds a subscriber to spot_ros2 to accept JointState messages on the /arm_joint_commands topic to execute (as fast as possible)
Goes along with bdaiinstitute/spot_wrapper#139

Testing Done

Tested with the Maple action_stack_spot package sending joint trajectories

@coveralls
Copy link

coveralls commented Sep 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10792882076

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 430 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 51.013%
Files with Coverage Reduction New Missed Lines %
spot_ros2/spot_ros2/spot_driver/spot_driver/spot_ros2.py 430 44.99%
Totals Coverage Status
Change from base Build 10792743249: -0.2%
Covered Lines: 1913
Relevant Lines: 3750
💛 - Coveralls

tcappellari-bdai
tcappellari-bdai approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@tcappellari-bdai tcappellari-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tcappellari-bdai tcappellari-bdai merged commit 97b484f into main Sep 10, 2024
5 checks passed
@tcappellari-bdai Graphite App
Copy link
Collaborator

Merge activity

@tcappellari-bdai tcappellari-bdai deleted the ll/add_jointstate_ros_support branch September 10, 2024 13:12
@khughes-bdai khughes-bdai mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcappellari-bdai tcappellari-bdai tcappellari-bdai approved these changes

@amessing-bdai amessing-bdai amessing-bdai approved these changes

@khughes-bdai khughes-bdai Awaiting requested review from khughes-bdai khughes-bdai is a code owner

@METEORITENMAX METEORITENMAX Awaiting requested review from METEORITENMAX METEORITENMAX is a code owner

@jbarry-bdai jbarry-bdai Awaiting requested review from jbarry-bdai jbarry-bdai is a code owner

@mpickett-bdai mpickett-bdai Awaiting requested review from mpickett-bdai mpickett-bdai is a code owner

@bhung-bdai bhung-bdai Awaiting requested review from bhung-bdai bhung-bdai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@llee-bdai @coveralls @tcappellari-bdai @amessing-bdai