[N/a] fix for launching the driver without the gripper #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2024 12:50
Signed-off-by: Katie Hughes <[email protected]>
Signed-off-by: Katie Hughes <[email protected]>
khughes-bdai
requested review from
METEORITENMAX,
jbarry-bdai,
amessing-bdai,
mpickett-bdai,
bhung-bdai and
tcappellari-bdai
as code owners
mhidalgo-bdai
approved these changes
Dec 5, 2024
Pull Request Test Coverage Report for Build 12185809300Details
💛 - Coveralls |
Signed-off-by: Katie Hughes <[email protected]>
tcappellari-bdai
approved these changes
Dec 5, 2024
AngelRodriguez8008
added a commit
to AngelRodriguez8008/spot_ros2
that referenced
this pull request
Dec 27, 2024
* main: [SW-1106] using custom launch actions from synchros2 (bdaiinstitute#537) [SW-1764] allow use of preferred_odom_frame parameter (bdaiinstitute#538) [dependabot] Bump ros_utilities from `5aa699a` to `539c962` (bdaiinstitute#535) [SW-1658] Allow body frame to be root of TF tree (bdaiinstitute#536) [N/a] fix for launching the driver without the gripper (bdaiinstitute#534) [MAPLE-681] Add robot_description_package as parameter to driver launch (bdaiinstitute#531) [dependabot] Bump ros_utilities from `e4d5c80` to `5aa699a` (bdaiinstitute#530) [dependabot] Bump ros_utilities from `02ca14e` to `e4d5c80` (bdaiinstitute#525) [dependabot] Bump ros_utilities from `5258a5a` to `02ca14e` (bdaiinstitute#524) [dependabot] Bump spot_wrapper from `76e522b` to `c78ebfb` (bdaiinstitute#523) [dependabot] Bump ros_utilities from `23a79c9` to `5258a5a` (bdaiinstitute#522) [N/A] bugfix: give new xacro arguments default values (bdaiinstitute#521) [SW-1507] gripperless URDF for Spot (bdaiinstitute#520) [SW-1539] don't publish images from hand camera if gripperless param set (bdaiinstitute#518) [SW-1466] ability to take joint gains in through a parameter file (bdaiinstitute#516) # Conflicts: # spot_driver/spot_driver/spot_ros2.py
AngelRodriguez8008
added a commit
to AngelRodriguez8008/spot_ros2
that referenced
this pull request
Dec 27, 2024
* main: [SW-1106] using custom launch actions from synchros2 (bdaiinstitute#537) [SW-1764] allow use of preferred_odom_frame parameter (bdaiinstitute#538) [dependabot] Bump ros_utilities from `5aa699a` to `539c962` (bdaiinstitute#535) [SW-1658] Allow body frame to be root of TF tree (bdaiinstitute#536) [N/a] fix for launching the driver without the gripper (bdaiinstitute#534) [MAPLE-681] Add robot_description_package as parameter to driver launch (bdaiinstitute#531) [dependabot] Bump ros_utilities from `e4d5c80` to `5aa699a` (bdaiinstitute#530) [dependabot] Bump ros_utilities from `02ca14e` to `e4d5c80` (bdaiinstitute#525) [dependabot] Bump ros_utilities from `5258a5a` to `02ca14e` (bdaiinstitute#524) [dependabot] Bump spot_wrapper from `76e522b` to `c78ebfb` (bdaiinstitute#523) [dependabot] Bump ros_utilities from `23a79c9` to `5258a5a` (bdaiinstitute#522) [N/A] bugfix: give new xacro arguments default values (bdaiinstitute#521) [SW-1507] gripperless URDF for Spot (bdaiinstitute#520) [SW-1539] don't publish images from hand camera if gripperless param set (bdaiinstitute#518) [SW-1466] ability to take joint gains in through a parameter file (bdaiinstitute#516) # Conflicts: # spot_driver/spot_driver/spot_ros2.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Having recently gotten access to a gripperless spot, I discovered some bugs that came from not correctly passing the gripperless parameter to SpotWrapper (this resulted in the robot trying to access gripper related servers and hanging).
Testing Done