Fixes TimeSync with robot #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschweig
requested review from
METEORITENMAX,
jbarry-bdai,
amessing-bdai,
mpickett-bdai,
bhung-bdai,
tcappellari-bdai and
khughes-bdai
as code owners
|
Thank you for the PR! It looks like the linting CI check is failing. On your branch, could you please run |
Signed-off-by: Manuel Schweiger <[email protected]>
Signed-off-by: Manuel Schweiger <[email protected]>
This reverts commit 323f55c. Signed-off-by: Manuel Schweiger <[email protected]>
Signed-off-by: Manuel Schweiger <[email protected]>
|
happy to help :) ran the formatter and added the sign-off so that DCO does not complain. CI should be ok now. |
khughes-bdai
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The DefaultTimeSyncApi is missing the
WaitForSynccall from Spot SDK. As a result the timesync cannot be established, especially when connecting via WIFI.I added the
WaitForSynccall to the DefaultTimeSyncApi with a timeout of 5 seconds (maybe create a config param for that) before checking the timesync withHasEstablishedTimeSyncThis results in a successful timesync even via WIFI over VPNs.
Corresponding issue:
#527
Testing Done