Extend response header autocompletion support #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <[email protected]>
mhidalgo-bdai
requested review from
jbarry-bdai,
heuristicus,
amessing-bdai,
khughes-bdai and
tcappellari-bdai
as code owners
Signed-off-by: Michel Hidalgo <[email protected]>
spot_wrapper/testing/helpers.py
Outdated
| from bosdyn.api.lease_pb2 import ResourceTree | ||
|
|
||
|
|
||
| class GeneralizedDecorator: | ||
| class ThinDecorator: |
There was a problem hiding this comment.
Any chance we can get a more descriptive name?
There was a problem hiding this comment.
I'm not always great with names. TransparentDecorator? ForwardingDecorator is almost tautological.
There was a problem hiding this comment.
Naming might be the hardest thinking in programming, but I can't tell you what a ThinDecorator does just by reading the name. Maybe just add a usage comment?
There was a problem hiding this comment.
How about ForwardingWrapper? Added in 6901afa
Pull Request Test Coverage Report for Build 9670158691Details
💛 - Coveralls |
Signed-off-by: Michel Hidalgo <[email protected]>
Pull Request Test Coverage Report for Build 9685899447Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
amessing-bdai
approved these changes
Jun 26, 2024
Pull Request Test Coverage Report for Build 9685951175Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #81. This patch extends the logic for response header autocompletion to gRPC services that are not unary in both request and response.