Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Calibration Fixes #136

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Small Calibration Fixes #136

merged 2 commits into from
Sep 3, 2024

Conversation

glvov-bdai
Copy link
Collaborator

@glvov-bdai glvov-bdai commented Sep 3, 2024 •
edited
Loading

Fix the link in the readme as well as argparse options for saving data/ (radian/degree selecttion)

Testing:
Ran the tool with updated argparse

@glvov-bdai Graphite App
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @glvov-bdai and the rest of your teammates on Graphite Graphite

@coveralls
Copy link

coveralls commented Sep 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10685183869

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 42.674%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spot_wrapper/calibration/calibrate_spot_hand_camera_cli.py 0 3 0.0%
Totals Coverage Status
Change from base Build 10564201700: -0.02%
Covered Lines: 1867
Relevant Lines: 4375
💛 - Coveralls

@glvov-bdai glvov-bdai marked this pull request as ready for review September 3, 2024 14:41
tcappellari-bdai
tcappellari-bdai approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@tcappellari-bdai tcappellari-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@glvov-bdai glvov-bdai merged commit d49ed6f into main Sep 3, 2024
7 checks passed
@glvov-bdai glvov-bdai deleted the 09-03-small_calibration_fixes branch September 3, 2024 14:43
This was referenced Sep 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcappellari-bdai tcappellari-bdai tcappellari-bdai approved these changes

@jbarry-bdai jbarry-bdai Awaiting requested review from jbarry-bdai jbarry-bdai is a code owner

@heuristicus heuristicus Awaiting requested review from heuristicus heuristicus is a code owner

@amessing-bdai amessing-bdai Awaiting requested review from amessing-bdai amessing-bdai is a code owner

@khughes-bdai khughes-bdai Awaiting requested review from khughes-bdai khughes-bdai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glvov-bdai @coveralls @tcappellari-bdai