Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-1712] Pin ubuntu version in workflows #151

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

baxelrod-bdai
Copy link
Collaborator

Change Overview

This is simply a find/replace of ubuntu-latest -> ubuntu-22.04. Because ubuntu-latest will become 24.04 soon. We should pin to 22.04 which matches our development environment.

Testing Done

None. This PR is the test. (Assuming this repo has CI)

@coveralls
Copy link

coveralls commented Jan 7, 2025

Pull Request Test Coverage Report for Build 12677757107

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.626%

Totals Coverage Status
Change from base Build 11857554227: 0.0%
Covered Lines: 1870
Relevant Lines: 4603

💛 - Coveralls

@glvov-bdai
Copy link
Collaborator

glvov-bdai commented Jan 7, 2025

LGTM - Recommend following DCO instructions shown in failing test to sign off

@baxelrod-bdai baxelrod-bdai force-pushed the baxelrod/SW-1712-pin-ubuntu-version-in-ci branch from c55dde2 to fccce9d Compare January 8, 2025 19:35
Copy link
Collaborator Author

baxelrod-bdai commented Jan 8, 2025

Merge activity

  • Jan 8, 2:39 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 8, 2:39 PM EST: A user merged this pull request with Graphite.

@baxelrod-bdai baxelrod-bdai merged commit 3b5fd5a into main Jan 8, 2025
3 checks passed
@baxelrod-bdai baxelrod-bdai deleted the baxelrod/SW-1712-pin-ubuntu-version-in-ci branch January 8, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants