Minor tweaks

PK9: Fix writing box bin of self-owned SV eggs clearing nickname trash, also clear any hint of trading completely
SAV1: ensure current box is index:0 if uninitialized

PKHeX.Core/PKM/PK9.cs

@@ -609,6 +609,9 @@ private void SetHandlerEggOT(ITrainerInfo tr)
         HandlingTrainerGender = 0;
         HandlingTrainerLanguage = 0;
 
+        MetDate = null;
+        MetLocation = 0;
+        Nickname = SpeciesName.GetSpeciesNameGeneration(Species, tr.Language, 9);
         Nickname = SpeciesName.GetEggName(tr.Language, 9);
         OriginalTrainerName = tr.OT;
         CurrentHandler = 0;

PKHeX.Core/Saves/SAV1.cs

@@ -145,6 +145,8 @@ protected override byte[] GetFinalData()
             bool newContent = AnyBoxSlotSpeciesPresent(current, boxSlotCount);
             if (newContent)
                 BoxesInitialized = boxInitialized = true;
+            else
+                current = CurrentBox = 0; // No content, reset to box 1.
         }
 
         for (int i = 0; i < BoxCount; i++)
@@ -154,7 +156,7 @@ protected override byte[] GetFinalData()
             var src = GetUnpackedBoxSpan(i);
 
             bool written = PokeList1.MergeSingles(src, dest, StringLength, boxSlotCount, false, boxInitialized);
-            if (written && i == CurrentBox)
+            if (written && i == current) // Ensure the current box is mirrored in the box buffer; easier than having dest be CurrentBox.
                 dest.CopyTo(Data.AsSpan(Offsets.CurrentBox));
         }
 

PKHeX.WinForms/Misc/ErrorWindow.cs

@@ -63,12 +63,12 @@ public Exception Error
         }
     }
 
-    public void LoadException(Exception ex, string friendlyMessage, bool allowContinue) => Invoke(() =>
+    public void LoadException(Exception ex, string friendlyMessage, bool allowContinue)
     {
         ShowContinue = allowContinue;
         Message = friendlyMessage;
         Error = ex;
-    });
+    }
 
     private void UpdateExceptionDetailsMessage()
     {

PKHeX.WinForms/Program.cs

@@ -68,9 +68,7 @@ private static void UIThreadException(object sender, ThreadExceptionEventArgs t)
         try
         {
             var e = t.Exception;
-            string errorMessage = IsPluginError<IPlugin>(e, out var pluginName)
-                ? $"An error occurred in a PKHeX plugin. Please report this error to the plugin author/maintainer.\n{pluginName}"
-                : "An error occurred in PKHeX. Please report this error to the PKHeX author.";
+            string errorMessage = GetErrorMessage(e);
             result = ErrorWindow.ShowErrorDialog(errorMessage, e, true);
         }
         catch (Exception reportingException)
@@ -83,6 +81,13 @@ private static void UIThreadException(object sender, ThreadExceptionEventArgs t)
             Application.Exit();
     }
 
+    private static string GetErrorMessage(Exception e)
+    {
+        return IsPluginError<IPlugin>(e, out var pluginName)
+            ? $"An error occurred in a PKHeX plugin. Please report this error to the plugin author/maintainer.\n{pluginName}"
+            : "An error occurred in PKHeX. Please report this error to the PKHeX author.";
+    }
+
     // Handle the UI exceptions by showing a dialog box, and asking the user if they wish to abort execution.
     // NOTE: This exception cannot be kept from terminating the application - it can only
     // log the event, and inform the user about it.
@@ -97,7 +102,8 @@ private static void CurrentDomain_UnhandledException(object sender, UnhandledExc
             }
             else if (ex != null)
             {
-                ErrorWindow.ShowErrorDialog("An unhandled exception has occurred.\nPKHeX must now close.", ex, false);
+                var msg = GetErrorMessage(ex);
+                ErrorWindow.ShowErrorDialog($"{msg}\nPKHeX must now close.", ex, false);
             }
             else
             {