fix: use proper octal notation for file permissions

Signed-off-by: Martin Styk <[email protected]>
beaker-project · Oct 28, 2024 · 33474d2 · 33474d2
1 parent a4ce071
commit 33474d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/LabController/src/bkr/labcontroller/log_storage.py b/LabController/src/bkr/labcontroller/log_storage.py
@@ -27,13 +27,13 @@ def open_ro(self):
         return open(self.path, 'r')
 
     def __enter__(self):
-        makedirs_ignore(os.path.dirname(self.path), 0755)
+        makedirs_ignore(os.path.dirname(self.path), 0o755)
         created = False
         if self.create:
             try:
                 # stdio does not have any mode string which corresponds to this 
                 # combination of flags, so we have to use raw os.open :-(
-                fd = os.open(self.path, os.O_RDWR | os.O_CREAT | os.O_EXCL, 0644)
+                fd = os.open(self.path, os.O_RDWR | os.O_CREAT | os.O_EXCL, 0o644)
                 created = True
             except (OSError, IOError) as e:
                 if e.errno != errno.EEXIST:

diff --git a/LabController/src/bkr/labcontroller/test_netboot.py b/LabController/src/bkr/labcontroller/test_netboot.py
@@ -314,7 +314,7 @@ def test_kernel_options_are_not_quoted(self):
 
     def test_doesnt_overwrite_existing_default_config(self):
         pxelinux_dir = os.path.join(self.tftp_root, 'pxelinux.cfg')
-        makedirs_ignore(pxelinux_dir, mode=0755)
+        makedirs_ignore(pxelinux_dir, mode=0o755)
         pxelinux_default_path = os.path.join(pxelinux_dir, 'default')
         # in reality it will probably be a menu
         custom = '''
@@ -378,7 +378,7 @@ def test_kernel_options_are_not_quoted(self):
 
     def test_doesnt_overwrite_existing_default_config(self):
         ipxe_dir = os.path.join(self.tftp_root, 'ipxe')
-        makedirs_ignore(ipxe_dir, mode=0755)
+        makedirs_ignore(ipxe_dir, mode=0o755)
         ipxe_default_path = os.path.join(ipxe_dir, 'default')
         # in reality it will probably be a menu
         custom = '''#!ipxe