Skip to content

Commit

Permalink
ci: enable unit tests in fedora targets
Browse files Browse the repository at this point in the history
Signed-off-by: Martin Styk <[email protected]>
  • Loading branch information
StykMartin committed Oct 29, 2024
1 parent a0971af commit 4f4dbfd
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 9 deletions.
1 change: 1 addition & 0 deletions .github/workflows/review-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ jobs:
- LabController
os-target:
- name: centos:7
- name: fedora:41
- name: quay.io/centos/centos:stream9
additional_repos: "crb"
additional_packages: "epel-release"
Expand Down
4 changes: 0 additions & 4 deletions .packit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ jobs:
targets:
- fedora-all-x86_64
identifier: fedora
actions:
post-upstream-clone:
# disable broken unit tests
- sed -i '/make check/d' beaker.spec

- job: copr_build
trigger: pull_request
Expand Down
8 changes: 5 additions & 3 deletions Client/src/bkr/client/tests/test_wizard.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

import unittest
from datetime import date

import six
from six.moves import StringIO

from bkr.client import wizard
Expand Down Expand Up @@ -163,6 +165,6 @@ def test_prints_full_heading(self, cpt_stdout):
type.heading()
cpt_stdout.seek(0)
printout = cpt_stdout.read()
self.assertRegexpMatches(printout, r'\bWhat is the type of test?\b')
self.assertRegexpMatches(printout, r'\bRecommended values\b')
self.assertRegexpMatches(printout, r'\bPossible values\b')
six.assertRegex(printout, r'\bWhat is the type of test?\b')
six.assertRegex(printout, r'\bRecommended values\b')
six.assertRegex(printout, r'\bPossible values\b')
4 changes: 2 additions & 2 deletions Common/bkr/common/test_schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ def assert_valid(self, xml):

def assert_not_valid(self, xml, error_message):
schema = lxml.etree.RelaxNG(self.schema_doc)
self.assert_(not schema.validate(lxml.etree.fromstring(xml)))
self.assertTrue(not schema.validate(lxml.etree.fromstring(xml)))
messages = [str(e.message) for e in schema.error_log]
self.assert_(error_message in messages, messages)
self.assertTrue(error_message in messages, messages)

class TaskSchemaTest(SchemaTestBase):

Expand Down

0 comments on commit 4f4dbfd

Please sign in to comment.