Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest distro args in pxemenu #241

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

cbouchar
Copy link
Contributor

For latest distros, the variables 'method' and 'repos' are not supported in beaker pxemenu. Replace with 'inst.repos' instead. The latest distros are
RHEL9, CentOSStream9, FedoraRawhide, FedoraELN, and Fedora34 and up.

Copy link

@jchristi jchristi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment from John that should be addressed.

LabController/src/bkr/labcontroller/pxemenu.py Outdated Show resolved Hide resolved
@cbouchar
Copy link
Contributor Author

Yes I'm working on it but need to change downstream first where I know full Unit Test suite runs which takes hours.

For latest distros, the variables 'method' and 'repos'
are not supported in beaker pxemenu.  Replace with
'inst.repos' instead.  The latest distros are
RHEL9, CentOSStream9, FedoraRawhide, FedoraELN, and
Fedora34 and up.
Copy link
Collaborator

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. With the caveat that I'm not that familiar with this part of the code base.

@cbouchar
Copy link
Contributor Author

I'm seeing things you all may not see cause of my RedHat users. They're a tough group but in the same breath good people.

@cbouchar
Copy link
Contributor Author

Just sharing..... When a system is booting up, you can interrupt the boot process and you can select a different distro from the pxemenu built on the LC via a cron job which calls beaker-pxemenu to build it. This enables you to access other distros configured in Beaker. Perhaps Martin has more to add.

@cbouchar cbouchar merged commit b739685 into beaker-project:python-3 Nov 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants