Added missing "needs" to GHA windows client workflows and fixed if on…

… build jobs
beamable · Jul 9, 2024 · 87ffe2d · 87ffe2d
1 parent 8bd6ad1
commit 87ffe2d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/build_linux_client.yml b/.github/workflows/build_linux_client.yml
@@ -79,7 +79,7 @@ jobs:
     # Only run this if the changes job actually detected changes OR if we are building all.
     # Empty array will be serialized as [] so you can simply check it in the if condition.
     # Second part of the condition just checks if it's not an empty string - that would mean some failure during changes job execution.
-    if: ${{ (!inputs.buildAll && needs.changes.outputs.BEAMPROJS != '[]' && needs.changes.outputs.BEAMPROJS != '') || inputs.buildAll }}
+    if: ${{ (needs.changes.outputs.BEAMPROJS != '[]' && needs.changes.outputs.BEAMPROJS != '') || inputs.buildAll }}
 
     strategy:
       max-parallel: 1

diff --git a/.github/workflows/build_linux_server.yml b/.github/workflows/build_linux_server.yml
@@ -58,7 +58,7 @@ jobs:
     # Only run this if the changes job actually detected changes OR if we are building all.
     # Empty array will be serialized as [] so you can simply check it in the if condition.
     # Second part of the condition just checks if it's not an empty string - that would mean some failure during changes job execution.
-    if: ${{ (!inputs.buildAll && needs.changes.outputs.BEAMPROJS != '[]' && needs.changes.outputs.BEAMPROJS != '') || inputs.buildAll }}
+    if: ${{ (needs.changes.outputs.BEAMPROJS != '[]' && needs.changes.outputs.BEAMPROJS != '') || inputs.buildAll }}
 
     strategy:
       max-parallel: 1

diff --git a/.github/workflows/build_windows_client.yml b/.github/workflows/build_windows_client.yml
@@ -77,12 +77,13 @@ jobs:
               - '*.uproject'
             
   build:
+    needs: changes
     uses: ./.github/workflows/build_windows.yml
 
     # Only run this if the changes job actually detected changes OR if we are building all.
     # Empty array will be serialized as [] so you can simply check it in the if condition.
     # Second part of the condition just checks if it's not an empty string - that would mean some failure during changes job execution.
-    if: ${{ (!inputs.buildAll && needs.changes.outputs.BEAMPROJS != '[]' && needs.changes.outputs.BEAMPROJS != '') || inputs.buildAll }}
+    if: ${{ (needs.changes.outputs.BEAMPROJS != '[]' && needs.changes.outputs.BEAMPROJS != '') || inputs.buildAll }}
 
     strategy:
       max-parallel: 2