-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beamer check: add initiate-l1-invalidations command #2144
Conversation
a65f6ab
to
0bba7ef
Compare
258fbc4
to
07a2a6b
Compare
Still missing; docs. 🤦 |
All in all, looks pretty good. I'd like to be aligned on my comment above though. What's also missing (but part of the description in #1646) are the prove() calls for OP Stack chains. |
Yeah, I realized that just after marking this ready for review. 🤦 |
I would be fine to push this into another PR cause we need to think a bit more about the information being passed here. For OP chains the finality period only starts after the prove() call was made, so we cannot really add the timestamp if the prove() didnt happen. Alos here another concern is, that i.e. in the agent we try to call the prove() regardless of the state root being published and simply retry. But this also takes a couple of minutes. So we may want to even think about pushing the prove out of the invalidation creation? With regards to testing, in order to really test it we would need an actual OP setup like in the e2e tests... |
dfaa42c
to
8f4ea9f
Compare
Alright, the docs are now also ready. 📜 |
a3816fe
to
9f63ac7
Compare
9f63ac7
to
9087d1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice 🍷
This PR is part of #1646, adding the
beamer check initiate-l1-invalidations
command.