Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify challenges #2202

Merged
merged 9 commits into from
Sep 12, 2023
Merged

Verify challenges #2202

merged 9 commits into from
Sep 12, 2023

Conversation

istankovic
Copy link
Contributor

Final part of #1646, this PR adds the beamer check verify-challenges command.

Coverage:
image

bilbeyt
bilbeyt reviewed Sep 8, 2023
View reviewed changes
docs/source/commands.rst Outdated Show resolved Hide resolved
bilbeyt
bilbeyt approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@bilbeyt bilbeyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good!

fredo
fredo reviewed Sep 8, 2023
View reviewed changes
beamer/check/commands.py Outdated Show resolved Hide resolved
fredo
fredo requested changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@fredo fredo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls Check Comment otherwise looks good!

@bilbeyt
Copy link
Contributor

bilbeyt commented Sep 12, 2023

as docs changed, you should adapt your doc change

@istankovic
Copy link
Contributor Author

as docs changed, you should adapt your doc change

Yeah, will rebase, thanks for the note. 👍

beamer: check: allow context account to be None
09e465c 
This is useful in cases where we don't need to send any transactions,
just check things on chain.
@istankovic istankovic force-pushed the verify-challenges branch 2 times, most recently from e11ffb1 to e9b5a16 Compare September 12, 2023 11:55
fredo
fredo approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@fredo fredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read my last comment, if you have any good idea how to solve it easily, then feel free to fix otherwise i'm fine as is

@istankovic istankovic merged commit a4d8483 into main Sep 12, 2023
1 check passed
@istankovic istankovic deleted the verify-challenges branch September 12, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilbeyt bilbeyt bilbeyt approved these changes

@fredo fredo fredo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@istankovic @bilbeyt @fredo