Fix keyword args in legacy CSV Importer #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremander
force-pushed
the
fix-importer-kwargs
branch
from
255dc43 to
7cbd51c
Compare
The keyword arguments passed to the deprecated importers.csv.Importer constructor were not forwarded to the parent class constructor.
dnicolodi
force-pushed
the
fix-importer-kwargs
branch
from
7cbd51c to
05b58b3
Compare
|
Thanks! I edited the commit message slightly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The named keyword arguments in the (v2 legacy)
beangulp.importers.csv.Importerdo not seem to get passed to the parent class in the__init__method. This can lead to unexpected behavior (for instance, I setinvert_signtoTrue, but it was silently ignored). To fix this, we supply the keyword arguments to the call tosuper().__init__.