importers.csvbase: Add CreditOrDebit column type #155
Merged
+80
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to parse statements where credit (positive amounts) and debits (negative amounts) are placed in different columns.
dnicolodi
force-pushed
the
csvbase-creditordebit
branch
from
f3437d0 to
16b43cb
Compare
wzyboy
reviewed
Jan 25, 2025
|
|
||
| def parse(self, credit, debit): | ||
| if credit and debit: | ||
| raise ValueError('credit and debit fields cannot be populated ar the same time') |
| def test_both_columns(self): | ||
| column = CreditOrDebit(0, 1) | ||
| func = column.getter(None) | ||
| with self.assertRaisesRegex(ValueError, 'credit and debit fields cannot be populated ar the same time'): |
|
Thanks for spotting the typos @wzyboy! Fixing them now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to parse statements where credit (positive amounts) and debits (negative amounts) are placed in different columns.