Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pytorch 4.x/1.0 compatibility, Visual Studio solution files #30

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

sytelus
Copy link

@sytelus sytelus commented Jan 21, 2019

This PR adds on the top of #9.

  • Add Pytorch 4.1 and 1.0 compatibility (mainly use item() instead of [0] and torch.no_grad()).
  • Also added VS solution files for easy debugging for users who might want to use it.

@sytelus sytelus changed the title Add Add Pytorch 4.x/1.0 compatibility, Visual Studio solution files Jan 21, 2019
@bearpaw
Copy link
Owner

bearpaw commented Jan 23, 2019

Thanks for the PR. I really appreciate your contribution of upgrading the code to Pytorch 0.4 and 1.0.

However, there is part of the contributions that I do not plan to include in this repo:

  • results folder
  • visual studio support. I would suggest the users who are interested in VS to see your repo.
  • Also what is the gradient ratio scheduler? Any references?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants