Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Validation for Registry URL Suffix During Beckn ONIX Setup #205

Closed
7 tasks done
emmayank opened this issue Sep 2, 2024 · 2 comments
Closed
7 tasks done

Add Validation for Registry URL Suffix During Beckn ONIX Setup #205

emmayank opened this issue Sep 2, 2024 · 2 comments
Assignees
Labels
beckn onix beckn onix project enhancement New feature or request

Comments

@emmayank
Copy link

emmayank commented Sep 2, 2024

Description

When setting up Beckn ONIX, particularly under Option 2 and then selecting either Option 2 (BAP) or Option 3 (BPP), add a validation check to ensure that the provided registry URL ends with the suffix /subscriber. This validation is necessary because the installation process will fail without this specific URL structure.

Goals

  • Ensure that the registry URL provided by users during setup includes the required /subscriber suffix.
  • Prevent installation errors by enforcing this validation.

Expected Outcome

  1. If a user provides a registry URL that does not end with /subscriber, an error message should be displayed, and the user should be prompted to correct the URL before proceeding.
  2. The installation should only continue if the registry URL is correctly formatted.

Acceptance Criteria

  • When setting up Beckn ONIX with Option 2 and selecting either BAP (Option 2) or BPP (Option 3), the system validates the registry URL to ensure it ends with /subscriber.
  • If the registry URL is invalid (does not end with /subscriber), an error message is displayed, and the user is prompted to enter a correct URL.
  • The installation process proceeds only when a valid registry URL is provided.
  • The code changes are reviewed and approved by the development team.
  • The updated setup process is tested to ensure the validation works correctly without causing other issues.

Mockups / Wireframes

N/A

Product Name

Beckn ONIX

Domain

N/A

Tech Skills Needed

Devops

Complexity

High

Category

Deployment

Sub Category

Installation

@emmayank emmayank added enhancement New feature or request beckn onix beckn onix project labels Sep 2, 2024
@viraj89 viraj89 mentioned this issue Sep 6, 2024
3 tasks
prasad-takale-eminds added a commit that referenced this issue Sep 9, 2024
prasad-takale-eminds added a commit that referenced this issue Sep 9, 2024
@prasad-takale-eminds
Copy link
Contributor

We have fixed the code and added the suffix validation for the registry URL.
PR: #216

Image

@emmayank
Copy link
Author

Review Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beckn onix beckn onix project enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants