Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onix bugfixes & validation #216

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Onix bugfixes & validation #216

merged 5 commits into from
Sep 20, 2024

Conversation

prasad-takale-eminds
Copy link
Contributor

@prasad-takale-eminds prasad-takale-eminds commented Sep 9, 2024 •
edited by emmayank
Loading

This was referenced Sep 9, 2024
Closed
Closed
vbabuEM
vbabuEM approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@vbabuEM vbabuEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. But this needs independent testing.

@emmayank @viraj89 We need some test support for ONIX software changes before release.

@prasad-takale-eminds prasad-takale-eminds mentioned this pull request Sep 12, 2024
Open
8 tasks
@prasad-takale-eminds
Copy link
Contributor Author

@emmayank Should merge this PR or should ask someone else to do one round of testing?

@prasad-takale-eminds prasad-takale-eminds mentioned this pull request Sep 13, 2024
Closed
6 tasks
@prasad-takale-eminds prasad-takale-eminds mentioned this pull request Sep 13, 2024
Closed
8 tasks
@emmayank emmayank changed the title Onix bugfix Onix bugfixes & validation Sep 17, 2024
@emmayank emmayank mentioned this pull request Sep 17, 2024
Open
3 tasks
@prasad-takale-eminds prasad-takale-eminds changed the base branch from main to develop September 20, 2024 04:56
@prasad-takale-eminds prasad-takale-eminds merged commit f1258f5 into develop Sep 20, 2024
@yesrag2309 yesrag2309 mentioned this pull request Sep 20, 2024
Open
3 tasks
@prasad-takale-eminds prasad-takale-eminds deleted the onix-bugfix branch December 2, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbabuEM vbabuEM vbabuEM approved these changes

@ankitShogun ankitShogun Awaiting requested review from ankitShogun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prasad-takale-eminds @vbabuEM