Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL Validator Throughout Beckn ONIX Installation #206

Closed
8 tasks done
emmayank opened this issue Sep 2, 2024 · 2 comments
Closed
8 tasks done

Add URL Validator Throughout Beckn ONIX Installation #206

emmayank opened this issue Sep 2, 2024 · 2 comments
Assignees
Labels
beckn onix beckn onix project enhancement New feature or request

Comments

@emmayank
Copy link

emmayank commented Sep 2, 2024

Description

Implement a URL validator across all options provided during the Beckn ONIX installation process. Currently, users can enter invalid URLs, which results in failures later in the process. The validator should ensure that only valid URLs are accepted at every step where a URL input is required.

Goals

  • Ensure that valid URLs are provided by the user at every stage of the Beckn ONIX installation process.
  • Prevent installation failures caused by invalid URLs.

Expected Outcome

  1. The URL validator checks each URL entered during the installation process, ensuring it conforms to the standard URL format.
  2. Users are immediately notified if they enter an invalid URL and prompted to correct it before proceeding.
  3. The installation process continues only if a valid URL is provided.

Acceptance Criteria

  • A URL validator is implemented for all steps in the Beckn ONIX installation process where a URL is required.
  • If an invalid URL is entered, an error message is displayed, and the user is prompted to provide a valid URL.
  • The validator checks for standard URL format, including protocol (e.g., http, https), domain, and any required paths or suffixes.
  • The installation process proceeds only when all entered URLs are valid.
  • The code changes are reviewed and approved by the development team.
  • The installation process is tested to ensure the validator works correctly across all options without causing unintended disruptions.

Mockups / Wireframes

N/A

Product Name

Beckn ONIX

Domain

N/A

Tech Skills Needed

Devops

Complexity

High

Category

Deployment

Sub Category

Installation

@emmayank emmayank added enhancement New feature or request beckn onix beckn onix project labels Sep 2, 2024
@viraj89 viraj89 mentioned this issue Sep 6, 2024
3 tasks
prasad-takale-eminds added a commit that referenced this issue Sep 9, 2024
prasad-takale-eminds added a commit that referenced this issue Sep 9, 2024
@prasad-takale-eminds
Copy link
Contributor

Added the URL validation in the script.
PR: #216

SS

Image

@emmayank
Copy link
Author

Review Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beckn onix beckn onix project enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants