(Nearly) full Login packet implementation #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements most of the Login packet (except deserialization of the player's skin) including verification of the token signatures.
Other changes I made outside of the Login packet itself:
ProtoCodecError::UTF8Error
now uses thestd::str::Utf8Error
type internally rather thanstd::string::FromUtf8Error
. Since theString
error can be converted into thestr
one, this makes it possible to use the error variant for bothstr
andString
conversions.