Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]: Fixed lots of bugs in the Level implementation #118

Merged
merged 31 commits into from
Jan 4, 2025
Merged

[Fix]: Fixed lots of bugs in the Level implementation #118

merged 31 commits into from
Jan 4, 2025

Conversation

akashic-records-of-the-abyss
Copy link
Contributor

@akashic-records-of-the-abyss akashic-records-of-the-abyss commented Jan 4, 2025 •
edited
Loading

This PR addresses some major issues with the level crate.

  1. The default implementation for WorldBlock couldnt be constructed
  2. Chunks not existing before would not be saved into the world
  3. Makes the API less convoluted to work with
  4. Adds better documentation to the FillFilter for the default implementation of LevelChunk
  5. Adds a fill method to the default implementation of SubChunk
  6. Makes the tests more robust
  7. Adds removal of Subchunks and Chunks
  8. A much easier RawWorldTrait to implement

@akashic-records-of-the-abyss
Allow users to specify default implementation for level
9d633a3
@akashic-records-of-the-abyss
Merge branch 'bedrock-crustaceans:main' into proto_rework
e8ee6c8
@akashic-records-of-the-abyss
Merge pull request #1 from akashic-records-of-the-abyss/proto_rework
0749d80 
Proto rework
@akashic-records-of-the-abyss
Update Cargo.toml
bca2217
@akashic-records-of-the-abyss
changed syntax
edf176c
@akashic-records-of-the-abyss
Update Cargo.toml
d180db8
@akashic-records-of-the-abyss
added propper close methods
e8a629a
@akashic-records-of-the-abyss
added filling function and fixed writer bugs
5328546
@akashic-records-of-the-abyss
Changed how the project is included
7c647a5
@akashic-records-of-the-abyss
Cleaned up fill function
dc314cd
@akashic-records-of-the-abyss
Made the level APIs more user friendly
449cde3
@akashic-records-of-the-abyss
Made clippy happy
ee2d460
@akashic-records-of-the-abyss
Revert "Made clippy happy"
b52b662 
This reverts commit ee2d460.
@akashic-records-of-the-abyss
Reapply "Made clippy happy"
4486a11 
This reverts commit b52b662.

	modified:   crates/level/src/level/db_interface/bedrock_key.rs
	modified:   crates/level/src/level/db_interface/rusty.rs
modified:   crates/level/src/level/level.rs
	modified:   crates/level/src/level/sub_chunk.rs
	modified:   crates/level/test_level/LOG
	modified:   crates/level/test_level/db/CURRENT
	modified:   crates/level/test_level/db/LOG
	modified:   crates/level/test_level/db/LOG.old
modified:   crates/level/tests/api_test.rs
@akashic-records-of-the-abyss
Merge branch 'dev' into proto_rework
c22917f
@akashic-records-of-the-abyss
Merge branch 'main' into proto_rework
20c15ad
@akashic-records-of-the-abyss
Merge pull request #2 from akashic-records-of-the-abyss/proto_rework
b270416 
Proto rework
theaddonn
theaddonn requested changes Jan 4, 2025
View reviewed changes
Copy link
Member

@theaddonn theaddonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite good, but could you also please write some proper examples for the world crate that show each niche in detail?

crates/level/Cargo.toml Show resolved Hide resolved
@theaddonn theaddonn added the C-Level Category: Level label Jan 4, 2025
@akashic-records-of-the-abyss
Copy link
Contributor Author

quite good, but could you also please write some proper examples for the world crate that show each niche in detail?

Yeah sure! If its ok could this be merged and i'll PR the examples in in a separate PR?

@theaddonn
Copy link
Member

theaddonn commented Jan 4, 2025 •
edited
Loading

fine with me! As long as you fix the dependency style

@theaddonn
Copy link
Member

I see some errors here

@theaddonn theaddonn merged commit 6e3c9e9 into bedrock-crustaceans:dev Jan 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theaddonn theaddonn Awaiting requested review from theaddonn

Assignees
No one assigned
Labels
C-Level Category: Level
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akashic-records-of-the-abyss @theaddonn