Correcting typo (TransportLater actually sounds nice!) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget to run rustfmt |
|
Also, could you please remove the pure udp transport stuff, it is not planned anymore and unneeded |
theaddonn
requested changes
Aug 6, 2024
| @@ -71,6 +71,8 @@ pub enum TransportLayerError { | |||
| IOError(#[from] Arc<IOError>), | |||
| #[error("Raknet UDP Error: {0}")] | |||
| RaknetUDPError(#[from] RaknetError), | |||
| #[error("UDP Error: {0}")] | |||
| UDPError(#[from] UdpError), | |||
| @@ -84,3 +86,11 @@ pub enum RaknetError { | |||
| #[error("Format Error: {0}")] | |||
| FormatError(String), | |||
| } | |||
|
|
|||
| #[derive(Error, Debug, Clone)] | |||
| pub enum UdpError { | |||
| // TODO Tcp(net::TcpStream), | ||
| // TODO Udp(net::UdpSocket) | ||
| // Tcp(std::net::TcpStream), | ||
| Udp(tokio::net::UdpSocket) //MCBE over UDP :sobb:?? |
| @@ -34,6 +34,22 @@ impl TransportLayerConnection { | |||
| .await | |||
| .map_err(|e| TransportLayerError::RaknetUDPError(RaknetError::SendError(e))) | |||
| } | |||
| TransportLayerConnection::Udp(conn) => { | |||
| @@ -81,6 +130,9 @@ impl TransportLayerConnection { | |||
| TransportLayerConnection::RaknetUDP(conn) => { | |||
| conn.close().await; | |||
| } | |||
| TransportLayerConnection::Udp(socket) => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.