Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Head] Try to fix open graph image #56

Merged
merged 1 commit into from
Jul 22, 2024
Merged

🐛 [Head] Try to fix open graph image #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/layouts/Page.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ const {id, title = 'Curtis Dulmage | UX Developer'} = Astro.props;

const DESCRIPTION = 'UX development portfolio for Curtis Dulmage';
const PERMALINK = new URL(Astro.url.pathname, Astro.site).href;
// new URL('/assets/dulmage-social.png', Astro.site).href;
const OG_IMAGE = '/assets/dulmage-social.png';
const OG_IMAGE = new URL('/assets/dulmage-social.png', Astro.site).href;
---

<!doctype html>
Expand Down
11 changes: 11 additions & 0 deletions src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,17 @@ main {
overflow: hidden;
}

/*
TODO: Experiment with this when Safari has better support.
At the moment, the site in "web app view" does not stretch
the full height of the viewport (likely because of `svh`).
*/
/*
.section:fullscreen {
height: 100dvh;
}
*/

.section-interior {
display: grid;
gap: var(--space-looser);
Expand Down