-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [Earwurm] Various bug fixes #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: de9c61d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
beefchimi
force-pushed
the
various-fixes
branch
2 times, most recently
from
December 6, 2023 21:54
1c25f0b
to
3555328
Compare
github-actions
bot
added
🛠️ Tooling
Relating to build tooling or deployment
🧰 Dependency
Any dependency change (add / remove / downgrade / update)
🧪 Testing
Relating to testing of this code
labels
Dec 20, 2023
beefchimi
force-pushed
the
various-fixes
branch
from
December 20, 2023 19:59
5ca8335
to
9b9d647
Compare
beefchimi
force-pushed
the
various-fixes
branch
from
December 20, 2023 22:53
edc039e
to
f548c40
Compare
beefchimi
force-pushed
the
various-fixes
branch
from
December 22, 2023 16:48
89e70fa
to
b574cbf
Compare
beefchimi
force-pushed
the
various-fixes
branch
2 times, most recently
from
December 22, 2023 16:58
af06071
to
c40fae8
Compare
github-actions
bot
added
the
📚 Documentation
Improvements or additions to documentation
label
Dec 22, 2023
beefchimi
force-pushed
the
various-fixes
branch
from
December 22, 2023 17:49
58bc19c
to
5f90b01
Compare
beefchimi
force-pushed
the
various-fixes
branch
from
December 22, 2023 21:16
d92ac93
to
fcee531
Compare
This was
linked to
issues
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐛 Bug
Something isn't working
🧰 Dependency
Any dependency change (add / remove / downgrade / update)
📚 Documentation
Improvements or additions to documentation
🔖 Release
Merge of this PR triggers a new release
🧪 Testing
Relating to testing of this code
🛠️ Tooling
Relating to build tooling or deployment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues
vitest
.speed
accessor now works as expected.Consumer facing changes
Sound
that was never "started".#handleEnded
when aSound
has never been played.neverStarted: boolean;
property in theSoundEndedEvent
.volume
change event forEarwurm
,Stack
, andSound
.mute
change event forEarwurm
,Stack
, andSound
.library
change event forEarwurm
.queue
change event forStack
.speed
change event forSound
.speed
Setter now clamps the value between0.25
and4
.progress
change event.progress
Getter.state > ending
value..stop()
vs a natural "end".statechange
events tostate
.mute = false
when "pausing".mute
change event.Stack
when.add()
is passed an identicalid + path
.LibraryKeys
type, instead usingStackIds[]
directly.tokens
object with some usual values.docs/api.md
to include details on all the newly added / changed code.Project development changes
async
tests.PrimitiveType
.arrayShallowEquals
,assertNumber
.linearRamp
.Known bugs
playbackRate
is not a direct "value multiplier" as we thought.currentTime
is the problem.detune
produce a different result?cents
into a "multiplier" (or however theprogress
math works out).Future tasks
examples.md
to include some of the new features.transition
tospeed
linear ramp.progress
calculations... but maybe it is as easy as:subtract
half oftransitionDuration
.add
half oftransitionDuration
.emitten
.ended
subscriptions, asempty()
appears to not allow any queued events to execute.empty
an option forexecuteQueue
?Considerations
linearRamp()
method onSound
to allow custom changes over time?transitions
feature obselete?transitions
whileEarwurm
is already initialized.Getter/Setter
.Earwurm
andStack
that allows syncing prop values.earwurmManager.setAll('speed', 1.25)
.