-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 [Website] Add some debugging UI #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c47319b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
🧪 Testing
Relating to testing of this code
📚 Documentation
Improvements or additions to documentation
labels
Jan 22, 2024
github-actions
bot
added
🧰 Dependency
Any dependency change (add / remove / downgrade / update)
🛠️ Tooling
Relating to build tooling or deployment
labels
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧰 Dependency
Any dependency change (add / remove / downgrade / update)
📚 Documentation
Improvements or additions to documentation
🧪 Testing
Relating to testing of this code
🛠️ Tooling
Relating to build tooling or deployment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR originally set out to just add some debugging UI to the
app > website
... but I made a decision about auto-suspension along the way and changed someEarwurm
behaviour.Added in this PR
.resume()
and.suspend()
methods exposed on theEarwurm
instance.Earwurm
state.Earwurm > play
event listener.boolean
update whenever theEarwurm
toggles between any sound playing and nothing playing.manager.on('play', (active) => console.log('is playing:', active.toString()))
.app > website
.website
(in any environment), you can append the?mode=debug
param to the end of the url.http://localhost:5173/earwurm/?mode=debug
Changed in this PR
play
event, it is now easy for consumers to specify this behaviour themselves.Earwurm
will attempt to optimisticallysuspend
whenever:Stacks
have been removed from theEarwurm
. instance..stop()
has been called on theEarwurn
instance.suspended
state when.play()
is called on aSound
..suspend()
fails.