✨ [Discord] Broader support for urls #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beefchimi
added
✨ Feature
🦋 Changeset detectedLatest commit: 371f305 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
📱 Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to support a few more variations for
discordURLS - albeit with limitations.discordapp.xyz/users/*(was already supported)discord.xyz/channels/*discord.gg/*These two new urls unfortunately make
preferredUrlunreliable. As such, I've had to add some snowflake code so that we can detectdiscordand call a special function just for retrieving 1 of 3 (4 if you count the fallback) preferred URLs.At some point, we will likely want to revise how
preferredUrl(andappUrl) work for all networks. There is a bit more context in this issue for Discord.Lastly, I've done a few small dependency bumps... this has resulted in a TypeScript warning because a
dev-configsdependency does not include the latest TypeScript version in its support range. So far, there does not appear to be any issues... but its something I should resolve.