Merge pull request #1569 from ReflectiveChimp/fix/zap-fee-skip-zero-a…

…ddress

Skip 0x0 address when determining zap fee receiver

src/api/zap/fees.ts

@@ -1,25 +1,40 @@
 import { addressBook } from '../../../packages/address-book/src/address-book';
 import { ApiChain } from '../../utils/chain';
 import { ProviderId } from './swap/providers';
+import { ZERO_ADDRESS } from '../../utils/address';
 
 export type ZapFee = {
   value: number;
   receiver?: string;
 };
 
 const DEFAULT_ZAP_FEE = 0.0005;
-export const getZapProviderFee = (provider: ProviderId, chain: ApiChain) => {
-  if (provider === 'odos')
+
+export const getZapProviderFee = (provider: ProviderId, chain: ApiChain): ZapFee => {
+  if (provider === 'odos') {
+    // It's static to the odos code config, we can't make it dynamic
     return {
       value: DEFAULT_ZAP_FEE,
-    }; //It's static to the odos code config, we can't make it dynamic
+    };
+  }
 
   const beefyPlatform = addressBook[chain].platforms.beefyfinance;
   if (!beefyPlatform) {
-    throw new Error('No Beefy Platform found for chain ' + chain);
+    throw new Error(`No Beefy Platform found for chain ${chain}`);
+  }
+
+  const receiver = [
+    beefyPlatform.treasurySwapper,
+    beefyPlatform.treasuryMultisig,
+    beefyPlatform.treasury,
+  ].find(a => !!a && a !== ZERO_ADDRESS);
+
+  if (!receiver) {
+    throw new Error(
+      `No fee receiver (treasurySwapper, or treasuryMultisig, or treasury) found for ${provider} on ${chain}`
+    );
   }
 
-  const receiver = beefyPlatform.treasurySwapper || beefyPlatform.treasuryMultisig || beefyPlatform.treasury;
   return {
     value: DEFAULT_ZAP_FEE,
     receiver: receiver,