Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BeefySwapper v2 #253

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

BeefySwapper v2 #253

wants to merge 2 commits into from

Conversation

ReflectiveChimp
Copy link
Contributor

@ReflectiveChimp ReflectiveChimp commented Nov 14, 2024 •
edited
Loading

@kexleyBeefy

  • update forge-std to 1.94 (for vm.expectPartialRevert, requires latest version of foundry)
  • update BaseTestHarness/WrapperTest/ProdVaultTest to use newer forge-std
  • Add multi-hop support to BeefySwapper
  • Add more tests for BeefySwapper
  • Make BeefySwapper implement IBeefySwapper
  • Add ability to set slippage by asset (pair)? with default fallback
  • Add tests for slippage settings
  • Make upgradable via timelock
  • Add test for upgradability
  • Way to toggle oracle check by pair (aka allow minAmountOut=0)

@ReflectiveChimp
update forge-std to 1.94 (requires latest version of foundry)
e7a185b 
update BaseTestHarness/WrapperTest/ProdVaultTest to use newer forge-std
@ReflectiveChimp
Add multi-hop support to BeefySwapper
667eb2c 
Add more tests for BeefySwapper
Make BeefySwapper implement IBeefySwapper
@ReflectiveChimp ReflectiveChimp changed the title Add multi-hop support to BeefySwapper BeefySwapper v2 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ReflectiveChimp