[feat] Support for TornadoVM Tensor types #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l generated classes
…o be serializable for XML format
…define them. TornadoVM should throw a message to assess this case.
jjfumero
reviewed
Sep 12, 2024
| @@ -40,6 +40,7 @@ public class TornadoSettingState implements PersistentStateComponent<TornadoSett | |||
| @OptionTag(converter = JdkConverter.class) | |||
| public Sdk JdkPath; | |||
| public int parameterSize; | |||
| public String tensorShapeDimensions; | |||
There was a problem hiding this comment.
Should we represent the dimension directly in an int value, instead of a String?
There was a problem hiding this comment.
yes, makes sense. I decided to keep it as String because I was getting exceptions due to serialization for the TornadoSettingState.java class. I will keep a note to refactor it in future PRs.
jjfumero
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added support for the TornadoVM Tensor types (Issue #25).
Now, plugin users can define the shape for the tensor types from the plugin configuration panel, similar to the max array size. This configuration is dynamic, and users can update to run next configurations. Then the generated kernels from TornadoVM are generating the acceleration artifacts based on the user-defined shapes.
Some screenshot about the new features:
Note: If the users want to run Tensor unit-tests but they do not define any shape, the default shape set by the plugin is 0, which forwards the misconfiguration to TornadoVM. In this case, TornadoVM should throw an invalid Shape configuration exception.
To test, you can use the
runIDEGradle option and open the new IDE. Then set your TornadoVM directory and the plugin configurations, and try the TestTensorTypes tests.