Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP returns codes incorrect for some endpoints #226

Open
gb-beng opened this issue Jun 23, 2022 · 1 comment
Open

HTTP returns codes incorrect for some endpoints #226

gb-beng opened this issue Jun 23, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@gb-beng
Copy link
Contributor

gb-beng commented Jun 23, 2022

Example where we would expect a 400

$  curl --include https://data.beeldengeluid.nl/gtaa/invalid
HTTP/1.1 200 OK
Date: Thu, 23 Jun 2022 13:37:11 GMT
Server: nginx/1.14.1
Content-Type: application/ld+json
Content-Length: 174
Access-Control-Allow-Origin: *

[
  {
    "@id": "http://data.beeldengeluid.nl/gtaa/invalid",
    "https://schema.org/publisher": [
      {
        "@id": "https://www.beeldengeluid.nl/"
      }
    ]
  }
]

Example where we would expect a 404

$ curl --include https://data.beeldengeluid.nl/gtaa/99999999999999999999999999999999999999
HTTP/1.1 200 OK
Date: Thu, 23 Jun 2022 13:37:14 GMT
Server: nginx/1.14.1
Content-Type: application/ld+json
Content-Length: 205
Access-Control-Allow-Origin: *

[
  {
    "@id": "http://data.beeldengeluid.nl/gtaa/99999999999999999999999999999999999999",
    "https://schema.org/publisher": [
      {
        "@id": "https://www.beeldengeluid.nl/"
      }
    ]
  }
]
@gb-beng gb-beng added the bug Something isn't working label Jun 23, 2022
@gb-beng
Copy link
Contributor Author

gb-beng commented Jun 23, 2022

Slightly related: #220 .

@gb-beng gb-beng changed the title GTAA API returns 200 instead of 400 or 404 HTTP returns codes incorrect for some endpoints Jun 24, 2022
@wmelder wmelder self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants