Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move validation of datacatalogs/sets/downloads from beng-lod-server to lod-importer #482

Open
mwigham opened this issue Mar 1, 2024 · 1 comment

Comments

@mwigham
Copy link
Contributor

mwigham commented Mar 1, 2024

The idea is that the beng-lod-server should only need to deliver what is in the triple store, without any checks or validation. Validation should occur at the point at which import is done. Otherwise we can have the situation that invalid data is present in the triple store, where it is accessible via the endpoint while the beng-lod-server will block it, creating disparities.

NB: validation of the datacatalog/set/download ID should still be done in the beng-lod-server, as that handles errors on the request side rather than on the data side.

@wmelder
Copy link
Contributor

wmelder commented Jun 6, 2024

I guess the issues on the spreadsheet dataset-importer show that validation on import is now realized. Validation on the beng-lod-server side is still in place in the datacatalog handler, so we might still consider to remove that, because it is duplicate.
But, it is not urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants