Switch to a dynamic framework. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
force-pushed
the
framework-lib
branch
from
dbe0553 to
7f4d6b1
Compare
|
See the Briefcase PR for details on the merge strategy for this template change. There is one change (in the binary tagging workflow) that will need to be rolled back once beeware/briefcase#1934 has been merged. |
4 tasks
mhsmith
reviewed
Aug 7, 2024
| @@ -82,7 +86,7 @@ int main(int argc, char *argv[]) { | |||
| } | |||
|
|
|||
| // Set the home for the Python interpreter | |||
| python_home = [NSString stringWithFormat:@"%@/support/python-stdlib", resourcePath, nil]; | |||
| python_home = [NSString stringWithFormat:@"%@/Python.framework/Versions/{{ cookiecutter.python_version|py_tag }}", frameworksPath, nil]; | |||
There was a problem hiding this comment.
Python.framework/Versions/{{ cookiecutter.python_version|py_tag }} appears 3 times in this function, and {{ cookiecutter.python_version|py_tag }} appears 5 times. Can we factor them out into variables?
mhsmith
approved these changes
Aug 11, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App template changes to support the use of a dynamically loaded Python.framework.
Refs beeware/Python-Apple-support#191
Also drops Python 3.8 support, and adds Python 3.13 support.
Briefcase-Repo: https://github.com/freakboy3742/briefcase.git
Briefcase-Ref: version-bumps
PR Checklist: