-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to define app permissions #1599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2024
4 tasks
mhsmith
reviewed
Jan 14, 2024
Co-authored-by: Malcolm Smith <[email protected]>
This was referenced Jan 15, 2024
mhsmith
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for an app to declare permissions, as well as some related extension points.
Adds initial cross-platform permissions for
camera
,microphone
,fine_location
,coarse_location
,background_location
, andphoto_library
. This is done by adding entries topyproject.toml
like:The cross-platform definitions are converted into platform-specific interpretations:
Info.plist
Info.plist
andEntitlements.plist
<uses-permission>
and<uses-feature>
content toAndroidManifest.xml
finish-args
to themanifest.yml
In addition, the platform-specific mechanisms (
Info.plist
etc) have been exposed so that apps can define platform-specific modifications and extensions that aren't covered by the cross-platform capabilities.info
definitionsinfo
andentitlement
definitionspermission
andfeature
definitions, plus extension points thats allow injection of arbitrary content intoAndroidManifest.xml
finish_arg
definitions, plusmodules_extra_content
to allow injection of arbitrary build rules into the Flatpak manifest.Requires the use of updated templates:
The tests (including app build tests) all pass because the extra template context generated by Briefcase is ignored if the template doesn't support the key. The template PRs are all based on this PR, so they're exercising the new template variables - although they're not actually doing anything with them (other than the defaults injected on macOS, Android and Flatpak)
Fixes #547.
PR Checklist: