Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on linux arm64 #2121

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Run CI on linux arm64 #2121

merged 3 commits into from
Jan 19, 2025

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Jan 18, 2025

Changes

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

- Consistently use ubuntu-24.04 over ubuntu-latest
Comment on lines 114 to 115
* AlmaLinux (e.g., ``almalinux:9``)
* Red Hat Enterprise Linux (e.g., ``redhat/ubi9:9``)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to bump these versions too....but they are broken. Looks like some -devel packages have been dropped...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh...

@freakboy3742
Copy link
Member

freakboy3742 commented Jan 19, 2025

I've approved beeware/.github#195; I presume the process here is to merge that PR, then re-run CI on this one in non-draft mode (EDIT: after removing the explicit branch reference)?

@rmartin16
Copy link
Member Author

I'll merge beeware/.github#195, update this PR to use the "real" workflow in beeware/.github, and then it'll be good.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the changenote; pending CI passing on mainline, this looks good otherwise.

Comment on lines 114 to 115
* AlmaLinux (e.g., ``almalinux:9``)
* Red Hat Enterprise Linux (e.g., ``redhat/ubi9:9``)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh...

@@ -0,0 +1 @@
Integration tests in CI now run on arm64 Linux.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be promoted to feature - "Linux on ARM is now a fully supported platform".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair; I'll call that out - although, I think I should say arm64 since things like Pi 2/3 aren't covered by this testing.

@rmartin16 rmartin16 marked this pull request as ready for review January 19, 2025 01:31
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit d3463fb into beeware:main Jan 19, 2025
57 checks passed
@rmartin16 rmartin16 deleted the ci-linux-arm64 branch January 19, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve support for Linux ARM64 images
2 participants