-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI on linux arm64 #2121
Run CI on linux arm64 #2121
Conversation
d4702e7
to
1e3c567
Compare
- Consistently use ubuntu-24.04 over ubuntu-latest
1e3c567
to
bb487ef
Compare
* AlmaLinux (e.g., ``almalinux:9``) | ||
* Red Hat Enterprise Linux (e.g., ``redhat/ubi9:9``) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to bump these versions too....but they are broken. Looks like some -devel
packages have been dropped...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh...
I've approved beeware/.github#195; I presume the process here is to merge that PR, then re-run CI on this one in non-draft mode (EDIT: after removing the explicit branch reference)? |
I'll merge beeware/.github#195, update this PR to use the "real" workflow in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about the changenote; pending CI passing on mainline, this looks good otherwise.
* AlmaLinux (e.g., ``almalinux:9``) | ||
* Red Hat Enterprise Linux (e.g., ``redhat/ubi9:9``) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh...
changes/2113.misc.rst
Outdated
@@ -0,0 +1 @@ | |||
Integration tests in CI now run on arm64 Linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be promoted to feature - "Linux on ARM is now a fully supported platform".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair; I'll call that out - although, I think I should say arm64 since things like Pi 2/3 aren't covered by this testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Changes
PR Checklist: