Merge pull request #83 from dgmouris/negative-percent-check-validator

Added negative check and is_percentage validator tests

changes/75.misc.rst

@@ -0,0 +1 @@
+Added a negative percentage check in the validator, and added less than dunder to Percentage class.

src/colosseum/units.py

@@ -144,6 +144,9 @@ def __eq__(self, other):
             return self.val == other.val and self.suffix == other.suffix
         return False
 
+    def __lt__(self, other):
+        return self.val < other.val
+
 
 px = PixelUnit()
 

src/colosseum/validators.py

@@ -89,6 +89,10 @@ def is_percentage(value):
         error_msg = 'Value {value} is not a Percent unit'.format(value=value)
         raise ValidationError(error_msg)
 
+    if value < units.Percent(0):
+        error_msg = 'Value {value} can not negative'.format(value=value)
+        raise ValidationError(error_msg)
+
     return value
 
 

tests/test_validators.py

@@ -1,20 +1,38 @@
 from unittest import TestCase
 
 from colosseum.shapes import Rect
-from colosseum.units import px
+from colosseum.units import px, percent
 from colosseum.validators import (
     ValidationError,
     is_border_spacing,
     is_cursor,
     is_integer,
     is_number,
+    is_percentage,
     is_quote,
     is_rect,
     is_uri,
 )
 from colosseum.wrappers import Quotes
 
 
+class PercentTests(TestCase):
+    def test_percentage(self):
+        percent_value = is_percentage("100%")
+
+        self.assertEqual(percent_value, 100*percent)
+        self.assertEqual(type(percent_value), type(percent))
+
+        with self.assertRaises(ValidationError):
+            is_percentage("-100%")
+
+        with self.assertRaises(ValidationError):
+            is_percentage("100")
+
+        with self.assertRaises(ValidationError):
+            is_percentage('spam')
+
+
 class NumericTests(TestCase):
 
     def test_integer(self):

tox.ini

@@ -21,14 +21,12 @@ deps =
 commands = flake8 {posargs}
 
 [testenv:towncrier-check]
-skip_install = True
 deps =
     {[testenv:towncrier]deps}
 commands =
     python -m towncrier.check
 
 [testenv:towncrier]
-skip_install = True
 deps =
     towncrier >= 18.5.0
 commands =