Ignore no-op window resize requests #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
I'm a little concerned about your description of events being triggered at the "wrong" times - that seems to suggest there's something deeper going on - but I can't argue that this change makes sense at a high level.
A small change to the release note, but otherwise this looks good. Thanks for the patch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #2364
Currently, all resize requests are passed down to the
impllayers, even when the same window size as the current size is requested. Although this is a no-op on most backends, but on some backends(like on gtk), this results in firing of window resize events at wrong times.Hence, this PR ignores such no-op window resize requests at the core, preventing them from being transmitted to the
impllayer.PR Checklist: