Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcery refactored main branch #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sourcery refactored main branch #43

wants to merge 1 commit into from

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Apr 20, 2022

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from belambert April 20, 2022 03:01
print('Sentence count: {}'.format(counter))
print(f'Sentence count: {counter}')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function main refactored with the following changes:

Comment on lines -231 to +236
if tag == 'insert':
for i in range(j1, j2):
word = seq2[i]
insertion_table[word] += 1
elif tag == 'delete':
if tag == 'delete':
for i in range(i1, i2):
word = seq1[i]
deletion_table[word] += 1
deletion_table[seq1[i]] += 1
elif tag == 'insert':
for i in range(j1, j2):
insertion_table[seq2[i]] += 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function track_confusions refactored with the following changes:

  • Simplify conditional into switch-like form (switch)
  • Inline variable that is only used once (inline-variable)

Comment on lines -301 to -302
# For insertions and deletions, put a filler of '***' on the other one, and
# make the other all caps
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function print_diff refactored with the following changes:

This removes the following comments ( why? ):

# For insertions and deletions, put a filler of '***' on the other one, and
# More complicated logic for a substitution
# make the other all caps

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Apr 20, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.68%.

Quality metrics Before After Change
Complexity 21.11 😞 18.81 😞 -2.30 👍
Method Length 102.79 🙂 102.29 🙂 -0.50 👍
Working memory 10.84 😞 10.74 😞 -0.10 👍
Quality 53.07% 🙂 53.75% 🙂 0.68% 👍
Other metrics Before After Change
Lines 330 323 -7
Changed files Quality Before Quality After Quality Change
asr_evaluation/asr_evaluation.py 53.07% 🙂 53.75% 🙂 0.68% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
asr_evaluation/asr_evaluation.py print_diff 56 ⛔ 411 ⛔ 21 ⛔ 6.97% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
asr_evaluation/asr_evaluation.py print_confusions 18 🙂 133 😞 10 😞 48.38% 😞 Try splitting into smaller methods. Extract out complex expressions
asr_evaluation/asr_evaluation.py process_line_pair 11 🙂 189 😞 10 😞 48.65% 😞 Try splitting into smaller methods. Extract out complex expressions
asr_evaluation/asr_evaluation.py track_confusions 18 🙂 82 🙂 12 😞 51.50% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants