Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect date format pattern in unit test #1789

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

Marcono1234
Copy link
Contributor

Fixes #1788

Regarding the change h ('clock-hour-of-am-pm (1-12)') to H ('hour-of-day (0-23)'):
Maybe the usage of h was intended before, since it is also using the US locale, however then maybe it should have included the am/pm marker?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ben-manes
Copy link
Owner

The static analyzers prefer an explicit locale. This is just for debugging the test so I think it’s okay. Thanks!

@ben-manes ben-manes merged commit 3457bf5 into ben-manes:master Oct 26, 2024
142 of 143 checks passed
@Marcono1234 Marcono1234 deleted the patch-1 branch October 26, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue30Test uses incorrect date time format pattern
3 participants