Skip to content

Commit

Permalink
backpedal on the static twig criticalcss idea
Browse files Browse the repository at this point in the history
  • Loading branch information
ben-rogerson committed Jul 5, 2019
1 parent 754da12 commit 3a235f5
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 20 deletions.
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"laravel-mix-purgecss": "^4.1.0",
"laravel-mix-stylelint": "^0.2.0",
"laravel-mix-svg-sprite": "^1.0.0",
"laravel-mix-twig-to-html": "^1.1.0",
"laravel-mix-twig-to-html": "^1.1.1",
"node-sass": "^4.12.0",
"postcss-preset-env": "^6.6.0",
"raw-loader": "^3.0.0",
Expand All @@ -47,16 +47,16 @@
"webpack": "^4.35.0"
},
"browserslist": [
"> 1%",
"last 2 versions",
"Firefox ESR",
"not ie 10",
"not op_mini all",
"not op_mob 12.1",
"not baidu 7.12",
"not ie_mob 10",
"not ie_mob 11",
"not and_uc 11.8"
"> 1%",
"last 2 versions",
"Firefox ESR",
"not ie 10",
"not op_mini all",
"not op_mob 12.1",
"not baidu 7.12",
"not ie_mob 10",
"not ie_mob 11",
"not and_uc 11.8"
],
"eslintConfig": {
"parser": "babel-eslint",
Expand Down
3 changes: 0 additions & 3 deletions src/templates/_layouts/base.twig
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<title>{{ title|default('No title') }}</title>

<!-- Display the critical css files in production -->
{{ criticalStyleFile(criticalCss|default()) }}

<!-- Your styles will be injected here -->
</head>

Expand Down
1 change: 0 additions & 1 deletion src/templates/blog/index.twig
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{% extends "../_layouts/base.twig" %}

{% set title = 'Blog' %}
{% set criticalCss = '' %}

{% block main %}

Expand Down
1 change: 0 additions & 1 deletion src/templates/index.twig
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{% extends "_layouts/base.twig" %}

{% set title = 'Agency Config' %}
{% set criticalCss = 'dist/critical-index.css' %}

{% block main %}

Expand Down
1 change: 0 additions & 1 deletion webpack.mix.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ mix.twigToHtml({
twigOptions: {
data: require(path.join(source.templates, '_data', 'data.js')),
},
publicFolder: path.join(__dirname, config.publicFolder),
})

/**
Expand Down

0 comments on commit 3a235f5

Please sign in to comment.