-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump min s2geography version to 0.2.0 #81
Conversation
Given spherely does not have any release compatible with 0.1.0 I don't see a reason to promise any backwards compatibility at this point. |
Yes I agree. I also think it will be unlikely to have s2geography as a common dependency of multiple downstream packages in the same environment so maintaining backwards compatibility probably won't be very useful anyway except for development iterations, keeping CI running, etc. between the releases. |
Yep, fully agreed just bumping the minimum version, and cleaning up the code. |
The geoarrow module uses the `py::capsule` constructor added in 2.11.0. https://pybind11.readthedocs.io/en/stable/changelog.html#version-2-11-0-july-14-2023
You can also remove some skips in the tests, eg Lines 10 to 13 in d40a8d2
|
This PR is ready for review. I'll implement new spherely features on top of s2geography 0.2.0 in follow-up PRs. |
For more context: - https://github.com/paleolimbot/s2geography/pull/32/files#r1865998806 - #22 (original PR) I'm not sure exactly what would be a proper fix, but at least this solves Spherely package builds (benbovy/spherely#81) and hopefully doesn't introduce regressions in other build configurations.
@jorisvandenbossche do you see any good reason to maintain compatibility with s2geography <0.2.0?
If not, I can remove the special cases (
#if
/#endif
pre-processor blocks) for s2geography < 0.2.0 and I can move forward here with some refactoring of core functionality (e.g., clone s2geography objects) that would otherwise be cumbersome to make if we want to maintain compatibility with older s2geography versions.