-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle exit code when calling resolve-import-conflicts #217
Conversation
@mernst You don't think it's better like this in one script? |
@mernst I am not a fan of the structured you proposed with calling another script, it creates too much dependencies between the scripts and too much calling around in my opinion. I looked at the script and made the return values explicit because it makes it easier to understand what we are trying to do here. For me in the current way it is a lot more intuitive. |
I was trying to leave AST-Merging-Evaluation functionality (like printing "Conflict" and running |
|
||
MERGE_SCRIPTS_DIR="$(cd "$(dirname "$0")" && pwd -P)" | ||
clone_dir=$1 | ||
branch1=$2 | ||
branch2=$3 | ||
strategy="-s ort" | ||
"$MERGE_SCRIPTS_DIR"/gitmerge.sh "$clone_dir" "$branch1" "$branch2" "$strategy" | ||
if ! "$MERGE_SCRIPTS_DIR"/gitmerge.sh "$clone_dir" "$branch1" "$branch2" "$strategy"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benedikt-schesch Why is this necessary? The script should exit with the same status as the last command in it, so this if
construct seems unnecessary (throughout).
#218 Is better |
No description provided.