-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ben merge analysis addition #253
Ben merge analysis addition #253
Conversation
@cactusbranch01 Good job style checks are passing. It looks pretty interesting, but Jupyter notebooks are just for prototyping, sadly, not for final code. It would be great if you could convert them to |
@cactusbranch01 Let us know when you have addressed @benedikt-schesch 's comments. Thanks! |
@cactusbranch01 Also when you will write the code make sure the code use proper type hints in the function arguments and return values. For more info: https://mypy.readthedocs.io/en/stable/cheat_sheet_py3.html |
fixed make style and pylint issues
- refactored merge to programmer_merge - added rm command (need to verify
…1/AST-Merging-Ben-Analysis into ben_merge_analysis
I recommend you run |
Do you mean to sync the fork before I send a pull request? Also, yes, I did run the style checks with "make style" and it looked like they scored 10/10. I'm just going to close this request, do that, then send another PR. |
Keep this PR open, I don't mean that. When you created this branch basically it was at a specfic version of main but main has changed now so you are no longer up to date with the latest code. There are two ways to fix this. 1) Rebase on main which basically adds all the missing commits but it's a huge mess bc you will have many merge conflicts (it's more clean though and ensures a more linear history). 2) Merge main into your branch, it will merge the current main into your branch and thus might only raise one single merge conflict. You should do 2 here. |
Okay, gotcha. I think the main branch is up to date in my branch now. I appreciate the help, and just let me know if there is anything else I should do. |
Added new analysis notebooks and one new script to clone a repo into a repos2 folder.