-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ben Scripts and Qualitative Analysis Code #279
Changes from 5 commits
45d5818
96a4262
5802ef8
6cd60d4
e36ccfe
b33ecb1
2e07556
e0084e5
ca10ec7
48af99c
c1b0289
785dd3c
34a89a0
3f10535
4cc20d4
35125e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# Python Scripts for Merge Conflict Analysis | ||
|
||
|
||
|
||
|
||
This directory contains Python scripts designed to facilitate the analysis of merge conflicts using various merge tools. The scripts allow users to recreate merges, analyze conflicts, and compare different merge algorithms' effectiveness. | ||
|
||
|
||
|
||
|
||
## Scripts Overview | ||
|
||
|
||
|
||
|
||
- `diff3_analysis.py`: This script analyzes merge conflicts for two merge tools on a given conflict. The tool that failed to merge should come first as an argument. | ||
|
||
|
||
|
||
|
||
## Prerequisites | ||
|
||
|
||
|
||
|
||
- Python 3.x installed on your system. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why doesn't this use the same setup as the rest of the project -- namely, the use of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, the setup is the same as the rest of the project, we still are using a conda or mamba environment. I think I will just delete this line since there is already another README that more thoroughly explains setup. Thanks! |
||
- Necessary Python packages installed (e.g., `pandas`, `GitPython`). | ||
|
||
|
||
|
||
|
||
## Usage | ||
|
||
|
||
|
||
|
||
### Analyzing a Single Merge Conflict | ||
|
||
|
||
|
||
|
||
To analyze a conflicts comparing two merge tools inside src/python run: | ||
|
||
|
||
python3 diff3_analysis.py <merge_tool1> <merge_tool2> <results_index> <output_directory> | ||
|
||
|
||
|
||
Ex: | ||
|
||
python3 diff3_analysis.py "gitmerge_ort" "spork" 32 "./mixed_results_spork" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't indexes contain a hyphen? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think in Python, CLI arguments are usually passed in as strings and its up to the script to interpret them as numbers. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I meant that indexes are now (for example) "38-3" rather than a number. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point. Now my scripts also use the idx column instead of the index in the spreadsheet. I updated the README and docs as well. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,259 @@ | ||
""" | ||
Recreates a merge and outputs the diff files for two algorithms for comparison on a given conflict. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the merge recreation, why not use the existing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, just added a few points on this in the README:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This has not answered the question. Why can't this script either call There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should be able to do that, it allows you to delete all the setup code since replay_merge does everything. I would suggest maybe just remove this script and adding a flag |
||
See src/python/README.md for details on usage. | ||
""" | ||
|
||
import sys | ||
import argparse | ||
import subprocess | ||
import re | ||
import os | ||
import shutil | ||
import tempfile | ||
import pandas as pd | ||
from repo import clone_repo_to_path | ||
from merge_tester import MERGE_STATE | ||
|
||
|
||
# pylint: disable-msg=too-many-locals | ||
# pylint: disable-msg=too-many-arguments | ||
|
||
|
||
def setup_environment(): | ||
"""Remove repository directories to clean up the environment.""" | ||
shutil.rmtree("./repos", ignore_errors=True) | ||
|
||
|
||
def clone_and_checkout(repo_name, branch_sha, clone_dir): | ||
""" | ||
Clone a repository to a specified path and checkout a given SHA. | ||
|
||
|
||
Args: | ||
repo_name (str): The repository to clone. | ||
branch_sha (str): The SHA commit or branch to checkout. | ||
clone_dir (str): Directory path to clone the repository. | ||
|
||
|
||
Returns: | ||
repo (GitPython.repo): The cloned repository object. | ||
""" | ||
repo = clone_repo_to_path(repo_name, clone_dir) | ||
repo.remote().fetch() | ||
repo.git.checkout(branch_sha, force=True) | ||
repo.submodule_update() | ||
return repo | ||
|
||
|
||
def process_diff( | ||
tool_name, base_path, attempt_path, merge_path, output_dir, index, filename | ||
): | ||
""" | ||
Process the diff between files and save the output to a designated file. | ||
|
||
Args: | ||
tool_name (str): Identifier for the merge tool. | ||
base_path (str): Path to the base file. | ||
attempt_path (str): Path to the merge attempt file. | ||
merge_path (str): Path to the manually merged file. | ||
output_dir (str): Directory where results will be saved. | ||
index (int): Index of the repository in the results list. | ||
filename (str): Base name for the output file. | ||
""" | ||
# Run diff3 or fall back to diff if files are missing | ||
diff_results = subprocess.run( | ||
["diff3", base_path, attempt_path, merge_path], | ||
stdout=subprocess.PIPE, | ||
stderr=subprocess.PIPE, | ||
text=True, | ||
) | ||
if "No such file or directory" in diff_results.stderr: | ||
diff_results = subprocess.run( | ||
["diff", attempt_path, merge_path], stdout=subprocess.PIPE, text=True | ||
) | ||
|
||
# Prepare the output filename | ||
diff_filename = os.path.join( | ||
output_dir, str(index), tool_name, f"diff_{filename}.txt" | ||
) | ||
os.makedirs( | ||
os.path.dirname(diff_filename), exist_ok=True | ||
) # Ensure the directory exists | ||
|
||
# Write the diff results to the file | ||
with open(diff_filename, "w") as diff_file: | ||
diff_file.write(diff_results.stdout) | ||
print(f"Diff results saved to {diff_filename}") | ||
|
||
|
||
def diff3_analysis( | ||
merge_tool1: str, merge_tool2: str, results_index: int, repo_output_dir | ||
): | ||
""" | ||
Analyzes merge conflicts using the diff3 tool and opens the results in the default text viewer. | ||
Args: | ||
merge_tool1 (str): The merge tool that Merge_failed (tool name as written in spreadsheet) | ||
merge_tool2 (str): The merge tool that Failed_tests or Passed_tests | ||
results_index (int): The index of the repository in the results spreadsheet. | ||
repo_output_dir (path): The path of where we want to store the results from the analysis | ||
|
||
|
||
Returns: | ||
None | ||
""" | ||
|
||
# Deletes base, programmer_merge, and merge_attempt folders in repos dir | ||
# We do this to prevent errors if cloning the same repo into the folder twice | ||
setup_environment() | ||
|
||
# Retrieve left and right branch from hash in repo | ||
df = pd.read_csv("../../results/combined/result.csv") | ||
repo_name = df.iloc[results_index]["repository"] | ||
|
||
script = "../scripts/merge_tools/" + merge_tool1 + ".sh" | ||
repo = clone_repo_to_path( | ||
repo_name, "./repos/merge_attempt1" | ||
) # Return a Git-Python repo object | ||
repo.remote().fetch() | ||
left_sha = df.iloc[results_index]["left"] | ||
repo.git.checkout(left_sha, force=True) | ||
repo.submodule_update() | ||
repo.git.checkout("-b", "TEMP_LEFT_BRANCH", force=True) | ||
repo.git.checkout(df.iloc[results_index]["right"], force=True) | ||
repo.submodule_update() | ||
repo.git.checkout("-b", "TEMP_RIGHT_BRANCH", force=True) | ||
print("Checked out left and right") | ||
|
||
# Clone the base | ||
base_sha = subprocess.run( | ||
[ | ||
"git", | ||
"merge-base", | ||
"TEMP_LEFT_BRANCH", | ||
"TEMP_RIGHT_BRANCH", | ||
], | ||
cwd="./repos/merge_attempt1/" + repo_name, | ||
stdout=subprocess.PIPE, | ||
text=True, | ||
) | ||
print("Found base sha" + base_sha.stdout) | ||
base_sha = base_sha.stdout.strip() | ||
repo2 = clone_and_checkout(repo_name, base_sha, "./repos/base") | ||
|
||
# Recreate the merge | ||
result = subprocess.run( | ||
[ | ||
script, | ||
repo.git.rev_parse("--show-toplevel"), | ||
"TEMP_LEFT_BRANCH", | ||
"TEMP_RIGHT_BRANCH", | ||
], | ||
stdout=subprocess.PIPE, | ||
text=True, | ||
) | ||
|
||
conflict_file_matches = re.findall( | ||
r"CONFLICT \(.+\): Merge conflict in (.+)", result.stdout | ||
) | ||
print(result.stdout) | ||
|
||
if conflict_file_matches == []: | ||
print("No conflict files to search") | ||
return | ||
|
||
repo3 = clone_and_checkout( | ||
repo_name, df.iloc[results_index]["merge"], "./repos/programmer_merge" | ||
) | ||
print(conflict_file_matches) | ||
|
||
script = "../scripts/merge_tools/" + merge_tool2 + ".sh" | ||
repo4 = clone_repo_to_path( | ||
repo_name, "./repos/merge_attempt2" | ||
) # Return a Git-Python repo object | ||
repo4.remote().fetch() | ||
left_sha = df.iloc[results_index]["left"] | ||
repo4.git.checkout(left_sha, force=True) | ||
print("Checking out left" + left_sha) | ||
repo4.submodule_update() | ||
repo4.git.checkout("-b", "TEMP_LEFT_BRANCH", force=True) | ||
repo4.git.checkout(df.iloc[results_index]["right"], force=True) | ||
print("Checking out right" + df.iloc[results_index]["right"]) | ||
repo4.submodule_update() | ||
repo4.git.checkout("-b", "TEMP_RIGHT_BRANCH", force=True) | ||
|
||
for conflict_file_match in conflict_file_matches: | ||
conflicting_file = str(conflict_file_match) | ||
conflict_path = os.path.join(repo_name, conflicting_file) | ||
conflict_file_base, _ = os.path.splitext(os.path.basename(conflicting_file)) | ||
|
||
# Paths for the first merge attempt | ||
conflict_path_merge_attempt1 = os.path.join( | ||
"./repos/merge_attempt1", conflict_path | ||
) | ||
conflict_path_base = os.path.join("./repos/base", conflict_path) | ||
conflict_path_programmer_merge = os.path.join( | ||
"./repos/programmer_merge", conflict_path | ||
) | ||
|
||
# Process the first merge attempt | ||
process_diff( | ||
merge_tool1, | ||
conflict_path_base, | ||
conflict_path_merge_attempt1, | ||
conflict_path_programmer_merge, | ||
repo_output_dir, | ||
results_index, | ||
conflict_file_base, | ||
) | ||
|
||
""" | ||
BREAK | ||
""" | ||
|
||
# Paths for the second merge attempt | ||
conflict_path_merge_attempt2 = os.path.join( | ||
"./repos/merge_attempt2", conflict_path | ||
) | ||
|
||
# Process the second merge attempt | ||
process_diff( | ||
merge_tool2, | ||
conflict_path_base, | ||
conflict_path_merge_attempt2, | ||
conflict_path_programmer_merge, | ||
repo_output_dir, | ||
results_index, | ||
conflict_file_base, | ||
) | ||
|
||
|
||
def main(): | ||
""" | ||
Parses arguments and calls diff3_analysis from the CLI | ||
""" | ||
parser = argparse.ArgumentParser( | ||
description="Process and compare merge conflicts using two tools." | ||
) | ||
parser.add_argument("merge_tool1", type=str, help="The first merge tool to use") | ||
parser.add_argument("merge_tool2", type=str, help="The second merge tool to use") | ||
parser.add_argument( | ||
"results_index", | ||
type=int, | ||
help="The index of the repository in the results spreadsheet", | ||
) | ||
parser.add_argument( | ||
"repo_output_dir", type=str, help="The directory to store the results" | ||
) | ||
|
||
args = parser.parse_args() | ||
|
||
diff3_analysis( | ||
merge_tool1=args.merge_tool1, | ||
merge_tool2=args.merge_tool2, | ||
results_index=args.results_index, | ||
repo_output_dir=args.repo_output_dir, | ||
) | ||
|
||
|
||
if __name__ == "__main__": | ||
main() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of extraneous whitespace in this README file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is standard. I think is designed to be seen from an end-users perspective like in the browser it looks normal.
https://github.com/cactusbranch01/AST-Merging-Ben-Analysis/blob/ben-main/src/python/README.md
If you think I should change this, though, I would be happy to.