Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adjacent merge tool #286

Merged
merged 34 commits into from
May 12, 2024
Merged

Update adjacent merge tool #286

merged 34 commits into from
May 12, 2024

Conversation

benedikt-schesch
Copy link
Owner

No description provided.

@benedikt-schesch
Copy link
Owner Author

@mernst In the small test the new tool that previously failed on both merges from https://github.com/benedikt-schesch/git-hires-merge-example are now passing with adjacent. I am not sure if that is expected behavior.

@benedikt-schesch
Copy link
Owner Author

@mernst I basically would like to make sure that no other functionality from the merge_tools repo bleed into the adjacent merge tool but not sure how to check that

@mernst
Copy link
Collaborator

mernst commented May 5, 2024

@benedikt-schesch Yes, success is expected, because both the adjacent tool first runs git merge-file and then does more work only if conflicts remain. For both pull requests on https://github.com/benedikt-schesch/git-hires-merge-example , git merge-file succeeds.

@benedikt-schesch benedikt-schesch merged commit 8ba56e9 into main May 12, 2024
6 checks passed
@benedikt-schesch benedikt-schesch deleted the update-adjacent branch May 12, 2024 06:29
benedikt-schesch added a commit that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants