Search code, repositories, users, issues, pull requests...

Trixi.jl/src/solvers/dg.jl

Lines 8 to 19 in 33903d9

    
           mutable struct P4estMPICache{BufferType <: DenseVector, VecInt <: DenseVector{<:Integer}} 
        
               mpi_neighbor_ranks::Vector{Int} 
        
               mpi_neighbor_interfaces::VecOfArrays{VecInt} 
        
               mpi_neighbor_mortars::VecOfArrays{VecInt} 
        
               mpi_send_buffers::VecOfArrays{BufferType} 
        
               mpi_recv_buffers::VecOfArrays{BufferType} 
        
               mpi_send_requests::Vector{MPI.Request} 
        
               mpi_recv_requests::Vector{MPI.Request} 
        
               n_elements_by_rank::OffsetArray{Int, 1, Array{Int, 1}} 
        
               n_elements_global::Int 
        
               first_element_global_id::Int 
        
           end

Trixi.Indexing module instead of symbols

Lines 755 to 778 in 33903d9

    
           # For some mesh types, elements next to a surface may have local coordinate systems 
        
           # that are not aligned so the nodes may have to be indexed differently. 
        
           # `IndexInfo` is used to describe how the nodes should be indexed. 
        
           # For example, in 2d a `Tuple` with two `IndexInfo` objects, one for each dimension, 
        
           # would be used. 
        
           # `first` or `last` indicates that the corresponding index is constant and is either 
        
           # the first or the last one. This effectively encodes the position of the surface 
        
           # with respect to the local coordinate system. The other `IndexInfo` object(s) 
        
           # encode if the index in the corresponding dimension is running forward or backward. 
        
           # 
        
           # The Enum is wrapped in a module and exported so that the enum values do not pollute 
        
           # the global namespace and can only be accessed via `Indexing.value`. 
        
           module Indexing 
        
           @enum IndexInfo begin 
        
               first 
        
               last 
        
               i_forward 
        
               i_backward 
        
               j_forward 
        
               j_backward 
        
           end 
        
           export IndexInfo 
        
           end 
        
           using .Indexing

Todos

Trixi.jl/src/solvers/dgsem_p4est/containers_parallel.jl

Line 230 in 33903d9

# TODO: Vector of Vector type data structure does not work on GPUs,
Trixi.jl/src/solvers/dgsem_p4est/dg_parallel.jl

Line 319 in 33903d9

# TODO reuse existing structures

…mework/Trixi.jl into feature-t8code-curved-geometry

it refers to level of refinement in lat lon direction, not number of tree as in the p4est version

…mework/Trixi.jl into feature-t8code-curved-geometry

…ubed-sphere-setup

MPI.jl's reduce currently does not work for custom operators (such as Trixi's min/max) on ARM

…ubed-sphere-setup

This reverts commit 6607023.

benegee · 2024-11-25T13:53:51Z

Concerning Trixi.Indexing:

Some containers contain symbols, e.g. node_indices in P4estInterfaceContainer. This can lead to errors like

KernelError: passing and using non-bitstype argument 
Argument 8 to your kernel function is of type Symbol, which is not isbits:

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/examples/structured_2d_dgsem/elixir_advection_meshview.jl

Line 58 in d942046

    
           x_neg = BoundaryConditionCoupled(2, (Indexing.last, Indexing.i_forward), Float64,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/examples/structured_2d_dgsem/elixir_advection_meshview.jl

Line 60 in d942046

    
           x_pos = BoundaryConditionCoupled(2, (Indexing.first, Indexing.i_forward), Float64,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/examples/structured_2d_dgsem/elixir_advection_meshview.jl

Line 66 in d942046

    
           x_neg = BoundaryConditionCoupled(1, (Indexing.last, Indexing.i_forward), Float64,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/examples/structured_2d_dgsem/elixir_advection_meshview.jl

Line 68 in d942046

    
           x_pos = BoundaryConditionCoupled(1, (Indexing.first, Indexing.i_forward), Float64,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/examples/structured_2d_dgsem/elixir_mhd_coupled.jl

Line 52 in d942046

    
           boundary_conditions1 = (x_neg = BoundaryConditionCoupled(2, (Indexing.last, Indexing.i_forward), Float64,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/examples/structured_2d_dgsem/elixir_mhd_coupled.jl

Line 54 in d942046

    
           x_pos = BoundaryConditionCoupled(2, (Indexing.first, Indexing.i_forward), Float64,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/examples/structured_2d_dgsem/elixir_mhd_coupled.jl

Line 75 in d942046

    
           boundary_conditions2 = (x_neg = BoundaryConditionCoupled(1, (Indexing.last, Indexing.i_forward), Float64,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/examples/structured_2d_dgsem/elixir_mhd_coupled.jl

Line 77 in d942046

    
           x_pos = BoundaryConditionCoupled(1, (Indexing.first, Indexing.i_forward), Float64,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/callbacks_step/analysis.jl

Line 624 in d942046

    
           l2_error, linf_error = calc_error_norms(u_ode_cpu, sol.t[end], analyzer, semi_cpu,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/semidiscretization/semidiscretization.jl

Line 109 in d942046

    
           if !(typeof(semi) <: SemidiscretizationHyperbolic) && !(typeof(semi.mesh) <: P4estMesh)

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/semidiscretization/semidiscretization_hyperbolic.jl

Line 40 in d942046

performance_counter::PerformanceCounter) where {Mesh, Equations,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/semidiscretization/semidiscretization_hyperbolic.jl

Line 45 in d942046

Cache}

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/semidiscretization/semidiscretization_hyperbolic.jl

Line 86 in d942046

cache, performance_counter)

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/semidiscretization/semidiscretization_hyperbolic.jl

Line 129 in d942046

cache, performance_counter)

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dg.jl

Line 764 in d942046

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 161 in d942046

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 308 to 309 in d942046

    
           neighbor_ids = unsafe_wrap_or_alloc(to, _neighbor_ids, size(interfaces.neighbor_ids)) 
        
           node_indices = unsafe_wrap_or_alloc(to, _node_indices, size(interfaces.node_indices))

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 452 in d942046

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 597 in d942046

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 97 in d942046

interfaces.node_indices[side, interface_id] = (Indexing.first, surface_index1,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 101 in d942046

interfaces.node_indices[side, interface_id] = (Indexing.last, surface_index1,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 105 in d942046

interfaces.node_indices[side, interface_id] = (surface_index1, Indexing.first,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 109 in d942046

interfaces.node_indices[side, interface_id] = (surface_index1, Indexing.last,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 114 in d942046

surface_index2, Indexing.first)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 118 in d942046

surface_index2, Indexing.last)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 130 in d942046

    
           boundaries.node_indices[boundary_id] = (Indexing.first, Indexing.i_forward, Indexing.j_forward)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 133 in d942046

    
           boundaries.node_indices[boundary_id] = (Indexing.last, Indexing.i_forward, Indexing.j_forward)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 136 in d942046

    
           boundaries.node_indices[boundary_id] = (Indexing.i_forward, Indexing.first, Indexing.j_forward)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 139 in d942046

    
           boundaries.node_indices[boundary_id] = (Indexing.i_forward, Indexing.last, Indexing.j_forward)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 142 in d942046

    
           boundaries.node_indices[boundary_id] = (Indexing.i_forward, Indexing.j_forward, Indexing.first)

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_p4est/containers_parallel.jl

Line 145 in d942046

    
           boundaries.node_indices[boundary_id] = (Indexing.i_forward, Indexing.j_forward, Indexing.last)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 204 in d942046

typeof(_u),

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 457 in d942046

    
           _prolong2mortars!(backend, cache, u, mesh, equations, mortar_l2, surface_integral, dg)

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 801 to 802 in d942046

    
           _calc_surface_integral!(backend, du, u, mesh, equations, surface_integral, dg, cache)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 14 in d942046

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 264 in d942046

    
           @kernel function interface_flux_kernel!(surface_flux_values, equations, surface_flux, nodes,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 353 in d942046

    
           @kernel function prolong2boundaries_kernel!(u_boundaries, neighbor_ids, _node_indices, u,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 504 in d942046

boundary_interp_factor_1, boundary_interp_factor_2,

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 512 to 513 in d942046

    
           surface_flux_values[v, l, m, 1, element] * 
        
           boundary_interp_factor_1)

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 517 to 519 in d942046

    
           surface_flux_values[v, l, m, 2, 
        
                               element] * 
        
           boundary_interp_factor_2)

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 523 to 524 in d942046

    
           surface_flux_values[v, l, m, 3, element] * 
        
           boundary_interp_factor_1)

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 528 to 530 in d942046

    
           surface_flux_values[v, l, m, 4, 
        
                               element] * 
        
           boundary_interp_factor_2)

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 534 to 535 in d942046

    
           surface_flux_values[v, l, m, 5, element] * 
        
           boundary_interp_factor_1)

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 539 to 541 in d942046

    
           surface_flux_values[v, l, m, 6, 
        
                               element] * 
        
           boundary_interp_factor_2)

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_p4est/dg_3d_gpu_parallel.jl

Line 591 in d942046

end # @muladd

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 160 in d942046

@inline function _prolong2mpimortars!(backend::Backend, cache, u,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_p4est/dg_3d_gpu_parallel.jl

Line 178 in d942046

end # @muladd

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 337 in d942046

mesh::Union{ParallelP4estMesh{3}, ParallelT8codeMesh{3}},

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 452 in d942046

    
           _calc_mpi_mortar_flux!(backend, surface_flux_values, mesh, nonconservative_terms, equations,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_p4est/dg_gpu_parallel.jl

Line 457 in d942046

mesh::Union{ParallelP4estMesh{3}, ParallelT8codeMesh{3}},

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 76 in d942046

end # @muladd

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 8 in d942046

    
           mutable struct P4estMPICache{BufferType <: DenseVector, VecInt <: DenseVector{<:Integer}}

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 51 in d942046

    
           mpi_neighbor_interfaces = Adapt.adapt_structure(to, mpi_cache.mpi_neighbor_interfaces)

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_structured/dg_3d.jl

Line 64 in d942046

    
           return P4estMPICache{BufferType, VecInt}(mpi_neighbor_ranks, mpi_neighbor_interfaces,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 793 in d942046

mesh::Union{StructuredMesh{3}, P4estMesh{3}, T8codeMesh{3}},

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 349 in d942046

0.07601887903440395,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 356 in d942046

4.848310144356219,

github-actions · 2024-12-16T11:31:17Z

examples/p4est_3d_dgsem/elixir_euler_source_terms_nonperiodic.jl

@@ -37,7 +38,7 @@ semi = SemidiscretizationHyperbolic(mesh, equations, initial_condition, solver,
 # ODE solvers, callbacks etc.

 tspan = (0.0, 5.0)
-ode = semidiscretize(semi, tspan)
+ode = semidiscretize(semi, tspan; adapt_to=CuArray)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

ode = semidiscretize(semi, tspan; adapt_to=CuArray)

ode = semidiscretize(semi, tspan; adapt_to = CuArray)

github-actions · 2024-12-16T11:31:17Z

examples/p4est_3d_dgsem/elixir_euler_taylor_green_vortex.jl

+function initial_condition_taylor_green_vortex(x, t, equations::CompressibleEulerEquations3D)
+  A  = 1.0 # magnitude of speed
+  Ms = 0.1 # maximum Mach number
+
+  rho = 1.0
+  v1  =  A * sin(x[1]) * cos(x[2]) * cos(x[3])
+  v2  = -A * cos(x[1]) * sin(x[2]) * cos(x[3])
+  v3  = 0.0
+  p   = (A / Ms)^2 * rho / equations.gamma # scaling to get Ms
+  p   = p + 1.0/16.0 * A^2 * rho * (cos(2*x[1])*cos(2*x[3]) + 2*cos(2*x[2]) + 2*cos(2*x[1]) + cos(2*x[2])*cos(2*x[3]))
+
+  return prim2cons(SVector(rho, v1, v2, v3, p), equations)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

function initial_condition_taylor_green_vortex(x, t, equations::CompressibleEulerEquations3D)

A = 1.0 # magnitude of speed

Ms = 0.1 # maximum Mach number

rho = 1.0

v1 = A * sin(x[1]) * cos(x[2]) * cos(x[3])

v2 = -A * cos(x[1]) * sin(x[2]) * cos(x[3])

v3 = 0.0

p = (A / Ms)^2 * rho / equations.gamma # scaling to get Ms

p = p + 1.0/16.0 * A^2 * rho * (cos(2*x[1])*cos(2*x[3]) + 2*cos(2*x[2]) + 2*cos(2*x[1]) + cos(2*x[2])*cos(2*x[3]))

return prim2cons(SVector(rho, v1, v2, v3, p), equations)

function initial_condition_taylor_green_vortex(x, t,

equations::CompressibleEulerEquations3D)

A = 1.0 # magnitude of speed

Ms = 0.1 # maximum Mach number

rho = 1.0

v1 = A * sin(x[1]) * cos(x[2]) * cos(x[3])

v2 = -A * cos(x[1]) * sin(x[2]) * cos(x[3])

v3 = 0.0

p = (A / Ms)^2 * rho / equations.gamma # scaling to get Ms

p = p +

1.0 / 16.0 * A^2 * rho *

(cos(2 * x[1]) * cos(2 * x[3]) + 2 * cos(2 * x[2]) + 2 * cos(2 * x[1]) +

cos(2 * x[2]) * cos(2 * x[3]))

return prim2cons(SVector(rho, v1, v2, v3, p), equations)

github-actions · 2024-12-16T11:31:17Z

examples/p4est_3d_dgsem/elixir_euler_taylor_green_vortex.jl

+solver = DGSEM(polydeg=3, surface_flux=flux_lax_friedrichs,
+               volume_integral=VolumeIntegralFluxDifferencing(flux_lax_friedrichs))


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

solver = DGSEM(polydeg=3, surface_flux=flux_lax_friedrichs,

volume_integral=VolumeIntegralFluxDifferencing(flux_lax_friedrichs))

solver = DGSEM(polydeg = 3, surface_flux = flux_lax_friedrichs,

volume_integral = VolumeIntegralFluxDifferencing(flux_lax_friedrichs))

github-actions · 2024-12-16T11:31:17Z

examples/p4est_3d_dgsem/elixir_euler_taylor_green_vortex.jl

+               volume_integral=VolumeIntegralFluxDifferencing(flux_lax_friedrichs))
+
+coordinates_min = (-1.0, -1.0, -1.0) .* pi
+coordinates_max = ( 1.0,  1.0,  1.0) .* pi


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

coordinates_max = ( 1.0, 1.0, 1.0) .* pi

coordinates_max = (1.0, 1.0, 1.0) .* pi

github-actions · 2024-12-16T11:31:18Z

examples/p4est_3d_dgsem/elixir_euler_taylor_green_vortex.jl

+mesh = P4estMesh(trees_per_dimension, polydeg=1,
+                 coordinates_min=coordinates_min, coordinates_max=coordinates_max,
+                 initial_refinement_level=2)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

mesh = P4estMesh(trees_per_dimension, polydeg=1,

coordinates_min=coordinates_min, coordinates_max=coordinates_max,

initial_refinement_level=2)

mesh = P4estMesh(trees_per_dimension, polydeg = 1,

coordinates_min = coordinates_min, coordinates_max = coordinates_max,

initial_refinement_level = 2)

github-actions · 2024-12-16T11:31:20Z

examples/structured_2d_dgsem/elixir_advection_coupled.jl

                                                      coupling_function31)
-boundary_conditions_y_pos3 = BoundaryConditionCoupled(1, (:i_forward, :begin), Float64,
+boundary_conditions_y_pos3 = BoundaryConditionCoupled(1, (Indexing.i_forward, Indexing.first), Float64,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

boundary_conditions_y_pos3 = BoundaryConditionCoupled(1, (Indexing.i_forward, Indexing.first), Float64,

boundary_conditions_y_pos3 = BoundaryConditionCoupled(1,

(Indexing.i_forward, Indexing.first),

Float64,

github-actions · 2024-12-16T11:31:20Z

examples/structured_2d_dgsem/elixir_advection_coupled.jl

@@ -157,13 +158,13 @@ coupling_function43 = (x, u, equations_other, equations_own) -> u
 coupling_function42 = (x, u, equations_other, equations_own) -> u

 # Define the coupling boundary conditions and the system it is coupled to.
-boundary_conditions_x_neg4 = BoundaryConditionCoupled(3, (:end, :i_forward), Float64,
+boundary_conditions_x_neg4 = BoundaryConditionCoupled(3, (Indexing.last, Indexing.i_forward), Float64,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

boundary_conditions_x_neg4 = BoundaryConditionCoupled(3, (Indexing.last, Indexing.i_forward), Float64,

boundary_conditions_x_neg4 = BoundaryConditionCoupled(3,

(Indexing.last, Indexing.i_forward),

Float64,

github-actions · 2024-12-16T11:31:20Z

examples/structured_2d_dgsem/elixir_advection_coupled.jl

                                                      coupling_function43)
-boundary_conditions_x_pos4 = BoundaryConditionCoupled(3, (:begin, :i_forward), Float64,
+boundary_conditions_x_pos4 = BoundaryConditionCoupled(3, (Indexing.first, Indexing.i_forward), Float64,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

boundary_conditions_x_pos4 = BoundaryConditionCoupled(3, (Indexing.first, Indexing.i_forward), Float64,

boundary_conditions_x_pos4 = BoundaryConditionCoupled(3,

(Indexing.first, Indexing.i_forward),

Float64,

github-actions · 2024-12-16T11:31:20Z

examples/structured_2d_dgsem/elixir_advection_coupled.jl

                                                      coupling_function43)
-boundary_conditions_y_neg4 = BoundaryConditionCoupled(2, (:i_forward, :end), Float64,
+boundary_conditions_y_neg4 = BoundaryConditionCoupled(2, (Indexing.i_forward, Indexing.last), Float64,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

boundary_conditions_y_neg4 = BoundaryConditionCoupled(2, (Indexing.i_forward, Indexing.last), Float64,

boundary_conditions_y_neg4 = BoundaryConditionCoupled(2,

(Indexing.i_forward, Indexing.last),

Float64,

github-actions · 2024-12-16T11:31:20Z

examples/structured_2d_dgsem/elixir_advection_coupled.jl

                                                      coupling_function42)
-boundary_conditions_y_pos4 = BoundaryConditionCoupled(2, (:i_forward, :begin), Float64,
+boundary_conditions_y_pos4 = BoundaryConditionCoupled(2, (Indexing.i_forward, Indexing.first), Float64,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

boundary_conditions_y_pos4 = BoundaryConditionCoupled(2, (Indexing.i_forward, Indexing.first), Float64,

boundary_conditions_y_pos4 = BoundaryConditionCoupled(2,

(Indexing.i_forward, Indexing.first),

Float64,

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 161 in 9c857e4

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 308 to 309 in 9c857e4

    
           neighbor_ids = unsafe_wrap_or_alloc(to, _neighbor_ids, size(interfaces.neighbor_ids)) 
        
           node_indices = unsafe_wrap_or_alloc(to, _node_indices, size(interfaces.node_indices))

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 452 in 9c857e4

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 597 in 9c857e4

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 97 in 9c857e4

interfaces.node_indices[side, interface_id] = (Indexing.first, surface_index1,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 101 in 9c857e4

interfaces.node_indices[side, interface_id] = (Indexing.last, surface_index1,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 105 in 9c857e4

interfaces.node_indices[side, interface_id] = (surface_index1, Indexing.first,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 109 in 9c857e4

interfaces.node_indices[side, interface_id] = (surface_index1, Indexing.last,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 114 in 9c857e4

surface_index2, Indexing.first)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 118 in 9c857e4

surface_index2, Indexing.last)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 130 in 9c857e4

    
           boundaries.node_indices[boundary_id] = (Indexing.first, Indexing.i_forward, Indexing.j_forward)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 133 in 9c857e4

    
           boundaries.node_indices[boundary_id] = (Indexing.last, Indexing.i_forward, Indexing.j_forward)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 136 in 9c857e4

    
           boundaries.node_indices[boundary_id] = (Indexing.i_forward, Indexing.first, Indexing.j_forward)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 139 in 9c857e4

    
           boundaries.node_indices[boundary_id] = (Indexing.i_forward, Indexing.last, Indexing.j_forward)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 142 in 9c857e4

    
           boundaries.node_indices[boundary_id] = (Indexing.i_forward, Indexing.j_forward, Indexing.first)

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_p4est/containers_parallel.jl

Line 145 in 9c857e4

    
           boundaries.node_indices[boundary_id] = (Indexing.i_forward, Indexing.j_forward, Indexing.last)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 204 in 9c857e4

typeof(_u),

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 457 in 9c857e4

    
           _prolong2mortars!(backend, cache, u, mesh, equations, mortar_l2, surface_integral, dg)

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 801 to 802 in 9c857e4

    
           _calc_surface_integral!(backend, du, u, mesh, equations, surface_integral, dg, cache)

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 14 in 9c857e4

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 264 in 9c857e4

    
           @kernel function interface_flux_kernel!(surface_flux_values, equations, surface_flux, nodes,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 353 in 9c857e4

    
           @kernel function prolong2boundaries_kernel!(u_boundaries, neighbor_ids, _node_indices, u,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 504 in 9c857e4

boundary_interp_factor_1, boundary_interp_factor_2,

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 512 to 513 in 9c857e4

    
           surface_flux_values[v, l, m, 1, element] * 
        
           boundary_interp_factor_1)

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 517 to 519 in 9c857e4

    
           surface_flux_values[v, l, m, 2, 
        
                               element] * 
        
           boundary_interp_factor_2)

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 523 to 524 in 9c857e4

    
           surface_flux_values[v, l, m, 3, element] * 
        
           boundary_interp_factor_1)

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 528 to 530 in 9c857e4

    
           surface_flux_values[v, l, m, 4, 
        
                               element] * 
        
           boundary_interp_factor_2)

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 534 to 535 in 9c857e4

    
           surface_flux_values[v, l, m, 5, element] * 
        
           boundary_interp_factor_1)

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 539 to 541 in 9c857e4

    
           surface_flux_values[v, l, m, 6, 
        
                               element] * 
        
           boundary_interp_factor_2)

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_p4est/dg_3d_gpu_parallel.jl

Line 591 in 9c857e4

end # @muladd

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 160 in 9c857e4

@inline function _prolong2mpimortars!(backend::Backend, cache, u,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_p4est/dg_3d_gpu_parallel.jl

Line 178 in 9c857e4

end # @muladd

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 337 in 9c857e4

mesh::Union{ParallelP4estMesh{3}, ParallelT8codeMesh{3}},

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 452 in 9c857e4

    
           _calc_mpi_mortar_flux!(backend, surface_flux_values, mesh, nonconservative_terms, equations,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_p4est/dg_gpu_parallel.jl

Line 457 in 9c857e4

mesh::Union{ParallelP4estMesh{3}, ParallelT8codeMesh{3}},

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 76 in 9c857e4

end # @muladd

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 8 in 9c857e4

    
           mutable struct P4estMPICache{BufferType <: DenseVector, VecInt <: DenseVector{<:Integer}}

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 51 in 9c857e4

    
           mpi_neighbor_interfaces = Adapt.adapt_structure(to, mpi_cache.mpi_neighbor_interfaces)

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_structured/dg_3d.jl

Line 64 in 9c857e4

    
           return P4estMPICache{BufferType, VecInt}(mpi_neighbor_ranks, mpi_neighbor_interfaces,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 793 in 9c857e4

mesh::Union{StructuredMesh{3}, P4estMesh{3}, T8codeMesh{3}},

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 349 in 9c857e4

0.07601887903440395,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_p4est/dg_3d_gpu_parallel.jl

Line 356 in 9c857e4

4.848310144356219,

github-actions · 2024-12-17T12:00:34Z

esiwace/elixirs/elixir_euler_taylor_green_vortex.jl

+
+function initial_condition_taylor_green_vortex(x, t,
+                                               equations::CompressibleEulerEquations3D)
+    A  = 1.0 # magnitude of speed


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

A = 1.0 # magnitude of speed

A = 1.0 # magnitude of speed

github-actions · 2024-12-17T12:00:35Z

esiwace/elixirs/elixir_euler_taylor_green_vortex.jl

+    v1  =  A * sin(x[1]) * cos(x[2]) * cos(x[3])
+    v2  = -A * cos(x[1]) * sin(x[2]) * cos(x[3])
+    v3  = 0.0
+    p   = (A / Ms)^2 * rho / equations.gamma # scaling to get Ms
+    p   = p + 1.0/16.0 * A^2 * rho * (cos(2*x[1])*cos(2*x[3]) +
+          2*cos(2*x[2]) + 2*cos(2*x[1]) + cos(2*x[2])*cos(2*x[3]))


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

v1 = A * sin(x[1]) * cos(x[2]) * cos(x[3])

v2 = -A * cos(x[1]) * sin(x[2]) * cos(x[3])

v3 = 0.0

p = (A / Ms)^2 * rho / equations.gamma # scaling to get Ms

p = p + 1.0/16.0 * A^2 * rho * (cos(2*x[1])*cos(2*x[3]) +

2*cos(2*x[2]) + 2*cos(2*x[1]) + cos(2*x[2])*cos(2*x[3]))

v1 = A * sin(x[1]) * cos(x[2]) * cos(x[3])

v2 = -A * cos(x[1]) * sin(x[2]) * cos(x[3])

v3 = 0.0

p = (A / Ms)^2 * rho / equations.gamma # scaling to get Ms

p = p +

1.0 / 16.0 * A^2 * rho *

(cos(2 * x[1]) * cos(2 * x[3]) +

2 * cos(2 * x[2]) + 2 * cos(2 * x[1]) + cos(2 * x[2]) * cos(2 * x[3]))

github-actions · 2024-12-17T12:00:35Z

esiwace/elixirs/elixir_euler_taylor_green_vortex.jl

+solver = DGSEM(polydeg=5, surface_flux=volume_flux,
+               volume_integral=VolumeIntegralFluxDifferencing(volume_flux))


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

solver = DGSEM(polydeg=5, surface_flux=volume_flux,

volume_integral=VolumeIntegralFluxDifferencing(volume_flux))

solver = DGSEM(polydeg = 5, surface_flux = volume_flux,

volume_integral = VolumeIntegralFluxDifferencing(volume_flux))

github-actions · 2024-12-17T12:00:35Z

esiwace/elixirs/elixir_euler_taylor_green_vortex.jl

+               volume_integral=VolumeIntegralFluxDifferencing(volume_flux))
+
+coordinates_min = (-1.0, -1.0, -1.0) .* pi
+coordinates_max = ( 1.0,  1.0,  1.0) .* pi


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

coordinates_max = ( 1.0, 1.0, 1.0) .* pi

coordinates_max = (1.0, 1.0, 1.0) .* pi

github-actions · 2024-12-17T12:00:35Z

esiwace/elixirs/elixir_euler_taylor_green_vortex.jl

+mesh = P4estMesh(trees_per_dimension, polydeg=1,
+                 coordinates_min=coordinates_min, coordinates_max=coordinates_max,
+                 periodicity=true, initial_refinement_level=initial_refinement_level)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

mesh = P4estMesh(trees_per_dimension, polydeg=1,

coordinates_min=coordinates_min, coordinates_max=coordinates_max,

periodicity=true, initial_refinement_level=initial_refinement_level)

mesh = P4estMesh(trees_per_dimension, polydeg = 1,

coordinates_min = coordinates_min, coordinates_max = coordinates_max,

periodicity = true, initial_refinement_level = initial_refinement_level)

github-actions · 2024-12-17T12:00:38Z

src/semidiscretization/semidiscretization_hyperbolic.jl

-        performance_counter = PerformanceCounter()
-
+                                                 cache::Cache,
+                                                 performance_counter::PerformanceCounter) where {Mesh, Equations,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

performance_counter::PerformanceCounter) where {Mesh, Equations,

performance_counter::PerformanceCounter) where {

Mesh,

Equations,

github-actions · 2024-12-17T12:00:38Z

src/semidiscretization/semidiscretization_hyperbolic.jl

+                                                                                                 BoundaryConditions,
+                                                                                                 SourceTerms,
+                                                                                                 Solver,
+                                                                                                 Cache}


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

Cache}

Cache

}

github-actions · 2024-12-17T12:00:38Z

src/semidiscretization/semidiscretization_hyperbolic.jl

    SemidiscretizationHyperbolic{typeof(mesh), typeof(equations),
                                 typeof(initial_condition),
                                 typeof(_boundary_conditions), typeof(source_terms),
                                 typeof(solver), typeof(cache)}(mesh, equations,
                                                                initial_condition,
                                                                _boundary_conditions,
                                                                source_terms, solver,
-                                                                cache)
+                                                                cache, performance_counter)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

cache, performance_counter)

cache,

performance_counter)

github-actions · 2024-12-17T12:00:38Z

src/semidiscretization/semidiscretization_hyperbolic.jl

+                                                                initial_condition,
+                                                                boundary_conditions,
+                                                                source_terms, solver,
+                                                                cache, performance_counter)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

cache, performance_counter)

cache,

performance_counter)

github-actions · 2024-12-17T12:00:38Z

src/solvers/dg.jl

@@ -752,6 +762,37 @@ function compute_coefficients!(u, func, t, mesh::AbstractMesh{3}, equations, dg:
    end
 end



[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 160 in fd5831e

@inline function _prolong2mpimortars!(backend::Backend, cache, u,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_p4est/dg_3d_gpu_parallel.jl

Line 178 in fd5831e

end # @muladd

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 337 in fd5831e

mesh::Union{ParallelP4estMesh{3}, ParallelT8codeMesh{3}},

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 452 in fd5831e

    
           _calc_mpi_mortar_flux!(backend, surface_flux_values, mesh, nonconservative_terms, equations,

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_p4est/dg_gpu_parallel.jl

Line 457 in fd5831e

mesh::Union{ParallelP4estMesh{3}, ParallelT8codeMesh{3}},

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 76 in fd5831e

end # @muladd

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 8 in fd5831e

    
           mutable struct P4estMPICache{BufferType <: DenseVector, VecInt <: DenseVector{<:Integer}}

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 51 in fd5831e

    
           mpi_neighbor_interfaces = Adapt.adapt_structure(to, mpi_cache.mpi_neighbor_interfaces)

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/src/solvers/dgsem_structured/dg_3d.jl

Line 64 in fd5831e

    
           return P4estMPICache{BufferType, VecInt}(mpi_neighbor_ranks, mpi_neighbor_interfaces,

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 793 in fd5831e

mesh::Union{StructuredMesh{3}, P4estMesh{3}, T8codeMesh{3}},

[JuliaFormatter] _{reported by reviewdog 🐶}

Line 349 in fd5831e

0.07601887903440395,

[JuliaFormatter] _{reported by reviewdog 🐶}