Fix profiling when python symbols aren't available. #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since python 3.10 - we haven't been able to profile python interpreters that have been compiled without symbols. This is because cpython changed where the 'PyRuntime' global is stored in python 3.10, from being in the BSS section into being in its own named section in the binary. This especially affected profiling on windows, where you'd have to install python symbols to be able to use py-spy. Fix by reading in the address/size of the the PyRuntime section from the elf/mach/pe binaries and using that to scan python interpreters when symbols aren't available.
This was referenced Oct 31, 2024
|
I believe you can also test this with the "stripped" variants of |
|
it would be pretty cool if we could test this out using a stripped build in CI - does the uv build strip out the PyRuntime symbol too ? (like what does something like show ?) In the short term, I'm testing this by verifying this fixes the windows wheels #543 - since this mostly impacts windows right now |
|
I've created #719 to track testing this functionality in CI - but I'm going to merge this change in now since it does fix the issue , and I've tested this manually to verify it works (and I'd like to get a release out =) |
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since python 3.10 - we haven't been able to profile python interpreters that have been compiled without symbols. This is because cpython changed where the 'PyRuntime' global is stored in python 3.10, from being in the BSS section into being in its own named section in the binary (python/cpython#4802)
This especially affected profiling on windows, where you'd have to install python symbols to be able to use py-spy.
Fix by reading in the address/size of the the PyRuntime section from the elf/mach/pe binaries and using that to scan python interpreters when symbols aren't available.