Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected docstring of new_vec method: it returns a column vector. #19

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

Mickanos
Copy link
Contributor

The implementation of the new_vec method for the Matrix struct seems to return a column vector:

    pub fn new_vec(data: Vec<F::Element>, field: F) -> Matrix<F> {
        Matrix {
            nrows: data.len() as u32,
            ncols: 1,
            data,
            field,
        }
    }

However, the original docstring states that the method returns a row vector:

/// Create a new row vector from a list of scalars.

The docstring is therefore updated to

/// Create a new column vector from a list of scalars.

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024

CLA assistant check
All committers have signed the CLA.

@Mickanos Mickanos marked this pull request as ready for review August 20, 2024 09:56
@benruijl
Copy link
Owner

benruijl commented Aug 21, 2024

Thanks! Can you also make the same change in python.rs and symbolica.py?

@benruijl benruijl closed this Aug 21, 2024
@benruijl benruijl reopened this Aug 21, 2024
@benruijl benruijl merged commit c182de1 into benruijl:main Aug 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants