Implemented AddAssign, SubAssign and MulAssign traits for Matrix. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benruijl
reviewed
Aug 21, 2024
src/tensors/matrix.rs
Outdated
| @@ -804,6 +844,11 @@ mod test { | |||
| assert_eq!(&c[1], &[139, 154]); | |||
| assert_eq!(c[(0, 1)], 64); | |||
|
|
|||
| let mut d = a.clone(); | |||
| d+= &a; | |||
There was a problem hiding this comment.
Can you run the auto-formatter (probably good to do it on-save)?
|
I realize I did not add the new methods to the Python API. I should probably do that. |
|
The are relevant, but I realize I haven't overloaded any other assignment operator yet, so I can also do that in bulk later for every type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the traits
AddAssign,SubAssignandMulAssignfor theMatrixtype. Addition and substraction make advantage of theadd_assignandsub_assignmethods for rings, whilemul_assignsimply reuses themulmethod ofMatrixand is only added for completeness.